[ 
https://issues.apache.org/jira/browse/OFBIZ-5126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13562713#comment-13562713
 ] 

Taher Alkhateeb commented on OFBIZ-5126:
----------------------------------------

Hi Jacques, thank you for the heads up, I will try to be more careful in issue 
submission for future cases.

One more comment: The patch setPriceRulesCondEventJs.patch contains "false" new 
argument. I am rethinking perhaps a better argument would be '' to stay 
consistent with the notation originally used in the file. If you wish I can 
revise the patch to reflect the same.
                
> Corrections and improvements to dependent drop-downs
> ----------------------------------------------------
>
>                 Key: OFBIZ-5126
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5126
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Taher Alkhateeb
>            Assignee: Jacques Le Roux
>              Labels: dropdownlist, freemarker, javascript
>             Fix For: Release Branch 11.04, SVN trunk, Release Branch 12.04
>
>         Attachments: getDependentDropdownValues.patch, 
> setDependentDropdownValuesJs.patch, setPriceRulesCondEventJs.patch
>
>
> The following items are included in this issue:
> 1) The setDependentDropdownValuesJs.ftl is using an incorrect argument which 
> usually happens to work because it is a duplicate of another. See patch for 
> details
> 2) The getDependentDropdownValues.js is modified with a new argument to allow 
> for empty selections. Therefore, copying the behavior of form widget 
> drop-down's "allow-empty"
> 3) There is only one file affected by item number 2 above, therefore, I fixed 
> it to include the argument in getDependentDropdownValues.js

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to