[ 
https://issues.apache.org/jira/browse/OFBIZ-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13612675#comment-13612675
 ] 

Christoph Neuroth commented on OFBIZ-5164:
------------------------------------------

Hmmm, that class already deals with with configuration, rendering, caching and 
transform loading. While I can see that huge god classes are a pattern in the 
code base I would rather stick to "one class, one responsibility" and use 
packages to structure related code... 
                
> Patch: Refactor Ofbiz*Transform to reduce deduplication
> -------------------------------------------------------
>
>                 Key: OFBIZ-5164
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5164
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Christoph Neuroth
>            Priority: Trivial
>         Attachments: OFBIZ-5164.patch
>
>
> Leaving the campground a bit cleaner than I found it, please find attached a 
> patch which removes some duplication from the *Transform classes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to