The ASL 2 license permits a copyright line. In fact their example includes one.

-Adrian

On 4/6/2013 10:06 AM, Jacques Le Roux wrote:
Hi Jacopo,

As you can see in the Jira, I ecked the jars were respectively under ASL2 and 
BSD.

But indeed, in the 3 GroovyShell*.java, I saw only the 1st part which says it's ASL2. I 
did not notice the last line , nor the line "Copyright 2007 Bruce Fancher". 
Which makes any sense to me. If it's ASL2 then you can't add anything else.

The original is 
http://docs.codehaus.org/display/GROOVY/Embedding+a+Groovy+Console+in+a+Java+Server+Application.
 I see no license reference there. No links from there works.

I personally see no problems reverting. If someone needs it then it's still in 
the repo... So maybe we should put a note in the Attic, with a reference to the 
Jira...

Jacques


From: "Jacopo Cappellato" <[email protected]>
I think that most of the code has been copied from here:

https://bitbucket.org/bkumar/spring-groovy-console/overview

I couldn't find a clear License and at this point, also considering that the 
shell is disabled by default and (I suspect) not used much, I think we should 
revert this commit.

Jacopo

On Apr 6, 2013, at 7:31 AM, Jacopo Cappellato 
<[email protected]> wrote:

Jacques,

did you notice the following licence headers when you committed the code from 
OFBIZ-3954? The are in three files and make me think that the contributor may 
have copied them: did you check if the original file was under a  license that 
allowed this?



As a side note: I discovered this because I am in the process of moving this 
code under the specialpurpose folder.

Jacopo

On Jan 23, 2011, at 6:58 PM, [email protected] wrote:

==============================================================================
--- 
ofbiz/trunk/framework/base/src/org/ofbiz/base/container/groovy/GroovyService.java
 (added)
+++ 
ofbiz/trunk/framework/base/src/org/ofbiz/base/container/groovy/GroovyService.java
 Sun Jan 23 17:58:43 2011
@@ -0,0 +1,85 @@
+/*
+ * Copyright 2007 Bruce Fancher
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *       http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+/*
+ * This file is a modified version of the original one.
+ */
+


Reply via email to