Re: svn commit: r1482067 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/StringUtil.java

[Adrian Crum]

Ummm...

I have a List in my hand. Instead of calling the size() method on that 
List, I hand it over to a method in another class that calls the size() 
method. How is that an optimization?

-Adrian

On 5/13/2013 9:06 PM, doo...@apache.org wrote:
Author: doogie
Date: Mon May 13 20:06:03 2013
New Revision: 1482067

URL: http://svn.apache.org/r1482067
Log:
OPTIMIZE: join() now calls UtilValidate.isEmpty().

Modified:
     ofbiz/trunk/framework/base/src/org/ofbiz/base/util/StringUtil.java

Modified: ofbiz/trunk/framework/base/src/org/ofbiz/base/util/StringUtil.java
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/src/org/ofbiz/base/util/StringUtil.java?rev=1482067&r1=1482066&r2=1482067&view=diff
==============================================================================
--- ofbiz/trunk/framework/base/src/org/ofbiz/base/util/StringUtil.java 
(original)
+++ ofbiz/trunk/framework/base/src/org/ofbiz/base/util/StringUtil.java Mon May 
13 20:06:03 2013
@@ -165,7 +165,7 @@ public class StringUtil {
       * @return a String of all values in the list seperated by the delimiter
       */
      public static String join(List<?> list, String delim) {
-        if (list == null || list.size() < 1)
+        if (UtilValidate.isEmpty(list))
              return null;
          StringBuilder buf = new StringBuilder();
          Iterator<?> i = list.iterator();