[
https://issues.apache.org/jira/browse/OFBIZ-5267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13738335#comment-13738335
]
Jacques Le Roux commented on OFBIZ-5267:
----------------------------------------
Hi Taher,
Thanks for inquiring, you have perfectly understood the three first points. Let
me clarify things a bit more. It seemed obvious to me, but it's maybe not.
Because it involves the notion of release.
I mentionned the point you restated in your point 4, only for completness. It's
unrelated to the problem at hand, we can forget it.
For your point 5: we did not really comment out the webapps from BIRT. At
r1361130, Jacopo <<Moved the "birt" component out of framework to
specialpurpose; moved all the birt reports from the applications to the birt
component itself, where the application webapps are overriden to inject the
reports; the end result is the same>>. I don't know if something changed since
he did it. I guess he tested it then, maybe not all cases: <<I did some cursory
tests but since the work has been challenging and rather complex I would
appreciate testing help and also reviews to finds chunks of code that I could
have missed and that could be moved out as well.>>.
Anyway, when running the trunk, we now face the small bug which was initially
the reason of this Jira issue. The bug is that we can't get to requests related
to birt report, because we miss a reference to this requests from the order
controller (and other applications controllers where birt reports are used,
namely accounting and facility).
A simple solution for the issue is this patch (similar for accounting and
facility controllers)
{code}
Index: applications/order/webapp/ordermgr/WEB-INF/controller.xml
===================================================================
--- applications/order/webapp/ordermgr/WEB-INF/controller.xml (revision
1512583)
+++ applications/order/webapp/ordermgr/WEB-INF/controller.xml (working copy)
@@ -23,6 +23,7 @@
<include
location="component://common/webcommon/WEB-INF/common-controller.xml"/>
<include location="component://commonext/webapp/WEB-INF/controller.xml"/>
<include
location="component://content/webapp/content/WEB-INF/controller.xml"/>
+ <include
location="component://birt/webapp/ordermgr/WEB-INF/controller.xml"/>
<description>Order Manager Module Site Configuration File</description>
<!-- event handlers -->
Index: specialpurpose/birt/webapp/ordermgr/WEB-INF/controller.xml
===================================================================
--- specialpurpose/birt/webapp/ordermgr/WEB-INF/controller.xml (revision
1512583)
+++ specialpurpose/birt/webapp/ordermgr/WEB-INF/controller.xml (working copy)
@@ -20,7 +20,6 @@
<site-conf xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/site-conf.xsd";>
- <include
location="component://order/webapp/ordermgr/WEB-INF/controller.xml"/>
<description>Extended Order Manager Controller Configuration
File</description>
{code}
The addition is to get access to birt reports from order component. The
deletion is to prevent a circular reference to order controller.
This issue does not exist in the new 13.07 release. Because, as you said, the
OrderPortletData.xml file is not loaded. Simply because the birt component was
removed from specialpurpose in the 13.07 release.
But if we fix in trunk with this patch we will then get this error in new
relases (ie 13.07 and future)
{code}
[java] 2013-08-13 16:14:02,546 (http-bio-0.0.0.0-8443-exec-6)
[ComponentLocationResolver.java:77 :ERROR]
[java] ---- exception report
----------------------------------------------------------
[java] Could not get root location for component with name [birt], error
was: org.ofbiz.base.component.ComponentException: No component found named :
birt
[java] Exception: org.ofbiz.base.component.ComponentException
[java] Message: No component found named : birt
[java] ---- stack trace
---------------------------------------------------------------
[java] org.ofbiz.base.component.ComponentException: No component found
named : birt
[java]
org.ofbiz.base.component.ComponentConfig.getComponentConfig(ComponentConfig.java:88)
[java]
org.ofbiz.base.component.ComponentConfig.getComponentConfig(ComponentConfig.java:63)
[java]
org.ofbiz.base.component.ComponentConfig.getRootLocation(ComponentConfig.java:276)
[java]
org.ofbiz.base.location.ComponentLocationResolver.getBaseLocation(ComponentLocationResolver.java:67)
[java]
org.ofbiz.base.location.ComponentLocationResolver.resolveLocation(ComponentLocationResolver.java:41)
[java]
org.ofbiz.base.location.FlexibleLocation.resolveLocation(FlexibleLocation.java:114)
[java]
org.ofbiz.base.location.FlexibleLocation.resolveLocation(FlexibleLocation.java:100)
[java]
org.ofbiz.webapp.control.ConfigXMLReader$ControllerConfig.loadIncludes(ConfigXMLReader.java:300)
[java]
org.ofbiz.webapp.control.ConfigXMLReader$ControllerConfig.<init>(ConfigXMLReader.java:107)
[java]
org.ofbiz.webapp.control.ConfigXMLReader.getControllerConfig(ConfigXMLReader.java:72)
[java]
org.ofbiz.webapp.control.RequestHandler.getControllerConfig(RequestHandler.java:98)
[java]
org.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:115)
[java]
org.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:214)
[java] javax.servlet.http.HttpServlet.service(HttpServlet.java:621)
[java] javax.servlet.http.HttpServlet.service(HttpServlet.java:722)
[java]
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:305)
[java]
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
[java]
org.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:314)
[java]
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:243)
[java]
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
[java]
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:222)
[java]
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:123)
[java]
org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:502)
[java]
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:171)
[java]
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:99)
[java]
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118)
[java]
org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:953)
[java]
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:408)
[java]
org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1023)
[java]
org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:589)
[java]
org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:312)
[java]
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
[java]
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
[java] java.lang.Thread.run(Thread.java:662)
[java]
--------------------------------------------------------------------------------
[java]
[java] 2013-08-13 16:14:02,546 (http-bio-0.0.0.0-8443-exec-6) [
ConfigXMLReader.java:303:ERROR]
[java] ---- exception report
----------------------------------------------------------
[java] Error processing include at
[component://birt/webapp/ordermgr/WEB-INF/controller.xml]:java.net.MalformedURLException:
Could not get root location for component with name [birt], error was: org.ofb
iz.base.component.ComponentException: No component found named : birt
[java] Exception: java.net.MalformedURLException
[java] Message: Could not get root location for component with name
[birt], error was: org.ofbiz.base.component.ComponentException: No component
found named : birt
[java] ---- stack trace
---------------------------------------------------------------
[java] java.net.MalformedURLException: Could not get root location for
component with name [birt], error was:
org.ofbiz.base.component.ComponentException: No component found named : birt
[java]
org.ofbiz.base.location.ComponentLocationResolver.getBaseLocation(ComponentLocationResolver.java:78)
[java]
org.ofbiz.base.location.ComponentLocationResolver.resolveLocation(ComponentLocationResolver.java:41)
[java]
org.ofbiz.base.location.FlexibleLocation.resolveLocation(FlexibleLocation.java:114)
[java]
org.ofbiz.base.location.FlexibleLocation.resolveLocation(FlexibleLocation.java:100)
[java]
org.ofbiz.webapp.control.ConfigXMLReader$ControllerConfig.loadIncludes(ConfigXMLReader.java:300)
[java]
org.ofbiz.webapp.control.ConfigXMLReader$ControllerConfig.<init>(ConfigXMLReader.java:107)
[java]
org.ofbiz.webapp.control.ConfigXMLReader.getControllerConfig(ConfigXMLReader.java:72)
[java]
org.ofbiz.webapp.control.RequestHandler.getControllerConfig(RequestHandler.java:98)
[java]
org.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:115)
[java]
org.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:214)
[java] javax.servlet.http.HttpServlet.service(HttpServlet.java:621)
[java] javax.servlet.http.HttpServlet.service(HttpServlet.java:722)
[java]
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:305)
[java]
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
[java]
org.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:314)
[java]
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:243)
[java]
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
[java]
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:222)
[java]
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:123)
[java]
org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:502)
[java]
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:171)
[java]
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:99)
[java]
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118)
[java]
org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:953)
[java]
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:408)
[java]
org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1023)
[java]
org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:589)
[java]
org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:312)
[java]
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
[java]
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
[java] java.lang.Thread.run(Thread.java:662)
[java]
--------------------------------------------------------------------------------
[java]
[java] 2013-08-13 16:14:02,546 (http-bio-0.0.0.0-8443-exec-6) [
ConfigXMLReader.java:116:INFO ] controller loaded: 0.0s, 357 requests, 145
views in jndi:/0.0.0.0/ordermgr/WEB-INF/controller.xml
{code}
Because we would refer to a missing component from the
order/accounting/facility controllers. This is the one I was referring to in my
point 1. I stated the solutions in my comment above.
To keep things clear, for the other issues I mentionned and for which you
proposed solutions, we should create another Jira...
> Net before overhead report generates an error
> ---------------------------------------------
>
> Key: OFBIZ-5267
> URL: https://issues.apache.org/jira/browse/OFBIZ-5267
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Pierre Smits
> Fix For: SVN trunk
>
>
> When trying to generate a 'Net Before Overhead Report' in ORDERMGR:Reports
> following error is shown:
> org.ofbiz.webapp.control.RequestHandlerException: Unknown request
> [NetBeforeOverheadReport.pdf]; this request does not exist or cannot be
> called directly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
