[ 
https://issues.apache.org/jira/browse/OFBIZ-5322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776243#comment-13776243
 ] 

Jacques Le Roux commented on OFBIZ-5322:
----------------------------------------

Actually it does paginate but the value is not dependent on widget property 
widget.form.defaultViewSize which default value is 20. It uses a default value 
of 50 which is defined by
{code}
<set field="viewSize" from-field="parameters.VIEW_SIZE" type="Integer" 
default-value="3"/>
{code}
You can easily test it using 
https://localhost:8443/manufacturing/control/FindRouting?VIEW_SIZE=3

This is legacy from pre Apache era. I found 143 cases where a default-value is 
defined in screens for VIEW_SIZE.

I did not look into details for the 143 cases but I believe most are also 
legacy.
There are few default values: 10, 20, 30, 50, 500 and even an extreme case of 
10000 for InventoryItemTotalsExport!
There is only one comment for LookupBulkAddProducts which is also legacy: <!-- 
10 rows seems more appropriate given screen size, etc. -->

I suggest to OOTB replace all those by the widget.form.defaultViewSize value. 
Things will then be consistent and easily changeable on a global scale using 
the widget property. 
Or if really needed forcing the default-value as it's done now.

So this would be applied on the 143 cases (I checked, viewSizeDefaultValue does 
not exist in any screen)

{code}
<property-to-field resource="widget" property="widget.form.defaultViewSize" 
field="viewSizeDefaultValue"/>
<set field="viewSize" from-field="parameters.VIEW_SIZE" type="Integer" 
default-value="${viewSizeDefaultValue}"/>
{code}

If nobody is against I will apply this pattern soon...



                
> Overview of routings does not paginate
> --------------------------------------
>
>                 Key: OFBIZ-5322
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5322
>             Project: OFBiz
>          Issue Type: Bug
>          Components: manufacturing
>    Affects Versions: SVN trunk
>            Reporter: Pierre Smits
>
> The routings overview in Manufacturing does not paginate.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to