[
https://issues.apache.org/jira/browse/OFBIZ-5312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13802934#comment-13802934
]
Jacques Le Roux edited comment on OFBIZ-5312 at 10/23/13 3:13 PM:
------------------------------------------------------------------
== TYPO ==
There was a small typo in previous patch: (.ftl.ftl.)
ofbizCatalogUrl=org.ofbiz.product.category.ftl.ftl.CatalogUrlSeoTransform
this one fixes it.
Anyway there is till this 404 issue Parimal spoke about and Jinghai is
investigating (I will not for now )
For instance on http://localhost:8080/ecommerce/product/Tiny-Gizmo-gz-1000.html
you get a 404 and in log:
{code}
[java] 2013-10-23 17:08:43,843 (http-bio-0.0.0.0-8080-exec-2) [
SeoContextFilter.java:264:WARN ] [Filtered request]: /ecommerce/images/blog.css
(404)
[java] 2013-10-23 17:08:43,843 (http-bio-0.0.0.0-8080-exec-2) [
ControlServlet.java:145:INFO ] [[[error(Domain:http://localhost)] Request
Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
[java] 2013-10-23 17:08:43,859 (http-bio-0.0.0.0-8080-exec-2) [
CmsEvents.java:145:INFO ] Path INFO for Alias: error/404.jsp
[...]
[java] 2013-10-23 17:09:04,281 (http-bio-0.0.0.0-8080-exec-5) [
CmsEvents.java:145:INFO ] Path INFO for Alias: product/Tiny-Gizmo-gz-1000.html
[java] 2013-10-23 17:09:04,296 (http-bio-0.0.0.0-8080-exec-5) [
CmsEvents.java:391:WARN ] Could not verify contentId [product] to webSiteId
[WebStore], returning code: 404
[java] 2013-10-23 17:09:04,406 (http-bio-0.0.0.0-8080-exec-5) [
RequestHandler.java:747:INFO ] Ran Event
[java:org.ofbiz.content.cms.CmsEvents#cms] from [request], result is [success]
{code}
was (Author: jacques.le.roux):
There was a small typo in previous patch: (.ftl.ftl.)
ofbizCatalogUrl=org.ofbiz.product.category.ftl.ftl.CatalogUrlSeoTransform
this one fix it.
Anyway there is till this 404 issue Parimal spoke about and Jinghai is
investigating (I will not for now )
For instance on http://localhost:8080/ecommerce/product/Tiny-Gizmo-gz-1000.html
you get a 404 and in log:
{code}
[java] 2013-10-23 17:08:43,843 (http-bio-0.0.0.0-8080-exec-2) [
SeoContextFilter.java:264:WARN ] [Filtered request]: /ecommerce/images/blog.css
(404)
[java] 2013-10-23 17:08:43,843 (http-bio-0.0.0.0-8080-exec-2) [
ControlServlet.java:145:INFO ] [[[error(Domain:http://localhost)] Request
Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
[java] 2013-10-23 17:08:43,859 (http-bio-0.0.0.0-8080-exec-2) [
CmsEvents.java:145:INFO ] Path INFO for Alias: error/404.jsp
[...]
[java] 2013-10-23 17:09:04,281 (http-bio-0.0.0.0-8080-exec-5) [
CmsEvents.java:145:INFO ] Path INFO for Alias: product/Tiny-Gizmo-gz-1000.html
[java] 2013-10-23 17:09:04,296 (http-bio-0.0.0.0-8080-exec-5) [
CmsEvents.java:391:WARN ] Could not verify contentId [product] to webSiteId
[WebStore], returning code: 404
[java] 2013-10-23 17:09:04,406 (http-bio-0.0.0.0-8080-exec-5) [
RequestHandler.java:747:INFO ] Ran Event
[java:org.ofbiz.content.cms.CmsEvents#cms] from [request], result is [success]
{code}
> Proposal: URL-Generation Changes
> --------------------------------
>
> Key: OFBIZ-5312
> URL: https://issues.apache.org/jira/browse/OFBIZ-5312
> Project: OFBiz
> Issue Type: New Feature
> Components: specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Minor
> Labels: changes, ecommerce, friendly, seo, url
> Fix For: SVN trunk
>
> Attachments: OFBIZ-5312 - ofbiz-ecommerce-seo.patch, OFBIZ-5312 -
> ofbiz-ecommerce-seo.patch, OFBIZ-5312 - ofbiz-ecommerce-seo.patch, OFBIZ-5312
> - ofbiz-ecommerce-seo.patch, OFBIZ-5312 - ofbiz-ecommerce-seo.patch,
> OFBIZ-5312 - ofbiz-ecommerce-seo.patch, OFBIZ-5312 -
> ofbiz-ecommerce-seo.patch, OFBIZ-5312 - ofbiz-ecommerce-seo.patch, OFBIZ-5312
> - ofbiz-ecommerce-seo.patch, OFBIZ-5312 - ofbiz-ecommerce-seo.patch,
> OFBIZ-5312 - ofbiz-ecommerce-seo.patch, SeoContextFilter.java.patch
>
>
> [This was proposed by Paul Piper in Nabble 7 months
> ago|http://ofbiz.135035.n4.nabble.com/Proposal-URL-Generation-Changes-td4639289.html].
> Here is quoted Paul's proposal
> {quote}
> Hey Everyone,
> over at ilscipio (www.ilscipio.com) we developed a set of functional OFBiz
> changes that we believe the entire community could benefit from. The changes
> have been implemented in parts in Syracus (www.syracus.net) for a while now,
> but we figured that some of which are too crucial for ofbiz' success in the
> long run, so we are considering the contribution (as we did with the SOLR
> component).
> As you are probably aware, OFBiz has a pretty uncommon way of generating
> URLs. Most of this has to do with the fact that OFBiz uses a servlet
> (ControlServlet) to handle all requests. The servlet is mounted at /control,
> so that it won't interfere with other servlets. Though functionally valid,
> this has the sideeffect that all urls are actually created on /control, which
> is neither pretty, nor good by any measures of SEO. It also means that a few
> 302 redirects are necessary to forward the user from / to /control/main. It
> also makes requests more complicated, since many forwards are necessary
> whenever somebody wants to move away from this implementation.
> Since this is hurtful to many of the implementers, I wanted to discuss
> whether or not you guys would be interested in the changes we have made. The
> functional changes contain:
> * Removal of /control out of all the urls
> * SEO-friendly URLS
> * Configurable product/category and other URLs
> * Frontpage mapping from /main to /
> It was tested on our end and contains all necessary improvements (Transforms,
> Sample Configuration, Servlets & Filters) for it to be applicable.
> If interested, I would create a new JIRA ticket for this and after a few
> minor internal discussions, we will gladly provide the rest of you with it.
> Regards,
> Paul
> {quote}
> There is even a patch, mostly done by Jinghai Shi, that I attach here. Even
> if it has been already used in [Syracus|http://syracus.net/] since early this
> year, some help would be needed to test it thoroughly in OFBiz.
> Then we should discuss if it's the way to go. I believe it is. Who needs a
> /control/ or /main by default in ecommerce urls? Would you not prefer
> http://localhost:8080/ecommerce/ over
> http://localhost:8080/ecommerce/control/main ?
--
This message was sent by Atlassian JIRA
(v6.1#6144)
