[
https://issues.apache.org/jira/browse/OFBIZ-5458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13864154#comment-13864154
]
Pierre Smits edited comment on OFBIZ-5458 at 1/7/14 12:41 PM:
--------------------------------------------------------------
I did a quick assessment on how often UtilProperties.getPropertyValue and
EntityUtilProperties.getProperties.GetPropertyValues occured in the code.
A search on UtilProperties.getPropertyValue matched 595 times across all
components in apps, framework and specpo.
520 in .java files (more than 100 - I stopped counting - including hard coded
default value
72 in .groovy files (15 including hard coded default value)
3 in .xml files
This included also 61 EntityUtilProperties.getPropertyValue finds.
A search on EntityUtilProperties.GetPropertyValue revealed:
- in apps accounting, content, marketing, order, party, product and securityext
- in framework common, minilang, webapp and widget
- in specpo ebay, ecommerce and googlebase
- 34 finds had a hard coded default value
- 5 finds had no delegator reference
An earlier assessment on entries in .properties files revealed that there were
over 1200 property definitions (not counting those in locale variations in
specpo pos). But there might be more in other configuration files with
different file extensions.
So there might also be a mismatch between definitions and usage, indicating
possible deprecated property definitions.
was (Author: pfm.smits):
I did a quick assessment on how often UtilProperties.getPropertyValue and
EntityUtilProperties.getProperties.GetPropertyValues occured in the code.
A search on UtilProperties.getPropertyValue matched 595 times across all
components in apps, framework and specpo.
520 in .java files (more than 100 - I stopped counting - including hard coded
default value
72 in .groovy files (15 including hard coded default value)
3 in .xml files
This included also 61 EntityUtilProperties.getPropertyValue finds.
A search on EntityUtilProperties.GetPropertyValue revealed:
- in apps accounting, content, marketing, order, party, product and securityext
- in framework common, minilang, webapp and widget
- in specpo ebay, ecommerce and googlebase
- 34 finds had a hard coded default value
- 5 finds had no delegator reference
An earlier assessment on entries in .properties files revealed that there were
over 1200 property definitions (not counting those in locale variations in
specpo pos). But there might be more in other configuration files with
different file extensions.
So there might also be a mismatch between definitions and usage, indicating
deprecated properties.
> getSystemPropertyValue is never called/used
> -------------------------------------------
>
> Key: OFBIZ-5458
> URL: https://issues.apache.org/jira/browse/OFBIZ-5458
> Project: OFBiz
> Issue Type: Bug
> Components: ALL APPLICATIONS, ALL COMPONENTS, framework
> Environment: multi-tenant multi-server
> Reporter: Pierre Smits
>
> getSystemPropertyValue which accesses and retrieves tenant specific
> properties is never called/used regarding default settings for a tenant.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
