This is actually a bug fix and another Jira issue is open for it: OFBIZ-5224. I guess it slipped in Pierre's OFBIZ-5523 patch. In a sense Pierre is
correct, and I checked the 1st part (simple-methods below) when I reviewed his 1st patch for OFBIZ-5523 some months ago
The simple-method issueProductionRunTaskComponent implements the service of
same name which is called by issueProductionRunTask, which correctly sets
<if-empty field="parameters.failIfItemsAreNotOnHand">
<set field="parameters.failIfItemsAreNotOnHand" value="Y"/>
</if-empty>
before calling issueProductionRunTaskComponent
But that's not all the story. Unfortunately, 1st time I did not check another call by updateProductionRunTask Java services, failIfItemsAreNotOnHand
is not set there , so the solution before was correct in this case.
I would revert this change, fixe both issues in another commit and backport and
close OFBIZ-5224, but I will wait Pierre's answer OFBIZ-5224 before.
Jacques
Le 25/04/2014 07:24, Jacopo Cappellato a écrit :
On Apr 24, 2014, at 10:23 PM, [email protected] wrote:
<simple-method method-name="issueProductionRunTask" short-description="Issues the Inventory
for a Production Run Task" login-required="false">
<entity-one entity-name="WorkEffort" value-field="workEffort"/>
@@ -159,7 +174,7 @@ under the License.
<if>
<condition>
<or>
- <if-empty
field="parameters.failIfItemsAreNotOnHand"/>
+ <if-compare field="parameters.failIfItemsAreNotAvailable"
operator="equals" value="Y" type="String"/>
<if-compare field="parameters.failIfItemsAreNotOnHand" operator="equals"
value="Y" type="String"/>
</or>
</condition>
I suspect this should not be part of the commit.
Jacopo
