[ 
https://issues.apache.org/jira/browse/OFBIZ-5565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14060067#comment-14060067
 ] 

Jacques Le Roux edited comment on OFBIZ-5565 at 7/13/14 11:03 AM:
------------------------------------------------------------------

I finally reopen this because there are currently some issues I found while 
testing OFBIZ-5640. 
# The finAccountCode is no longer encrypted, while demo data are still. We 
should continue to encode it. Most the demo data need though to be revisited, 
this is another issue, I could not remember/find if we created one specifically 
for that, though Adam spoke about revisiting encrypted demo data in this 
OFBIZ-3006 
[comment|https://issues.apache.org/jira/browse/OFBIZ-3006?focusedCommentId=14037612]
# Since the data are not saved encrypted and demo data encrypted are not for 
now, this line 
{code}
finAccountCode = finAccountCode.toUpperCase().replaceAll("[^0-9A-Z]", "");
{code}
in the FinAccountHelper.getFinAccountFromCode()  method should be commented out 
(and commented with a FIXME) waiting for encryption and revisited demo data


was (Author: jacques.le.roux):
I finally reopen this because there are currently some issues I found while 
testing OFBIZ-5640. 
# The finAccountCode is no longer encrypted, while demo data are still. We 
should continue to encode it. Most the demo data need though to be revisited, 
this is another issue, I could not remember/find if we created one specifically 
for that, though Adam spoke about revisiting encrypted demo data in this 
OFBIZ-3006 
[comment|https://issues.apache.org/jira/browse/OFBIZ-3006?focusedCommentId=14037612]
# Since the data are not saved encrypted and demo data encrypted are not for 
now, this line 
{code}
finAccountCode = finAccountCode.replaceAll("[^0-9A-Z]", "");
{code}
in the FinAccountHelper.getFinAccountFromCode()  method should be commented out 
(and commented with a FIXME) waiting for encryption and revisited demo data

> FinAccountHelper.getFinAccountFromCode() no longer returns financial account
> ----------------------------------------------------------------------------
>
>                 Key: OFBIZ-5565
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5565
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting, order
>    Affects Versions: Release Branch 13.07, Trunk
>         Environment: Primarily tested on Ubuntu, but affects all OS.
>            Reporter: Vyom Jain
>            Assignee: Adam Heath
>             Fix For: Trunk
>
>         Attachments: OFBIZ-5565.patch
>
>
> FinAccountHelper.getFinAccountFromCode() in trunk as well as in some of the 
> released versions is no longer able to fetch the Financial Account ID. 
> So all features dependent on this method would no longer work (an example 
> being paying by gift card during order entry process).
> Per my research, this stopped working method post some changes related to how 
> data is encrypted (two strings will not have similar encrypted string).
> I had tried this on a fresh SVN trunk checkout with absolutely no changes 
> (had been using Derby database).
> Furthermore, the ant target gen-kek references old jars and that needs fixing 
> as well.
> Steps to test - 
> 1. Create a new Financial account (gift certificate) for DemoCustomer - 
> https://demo-trunk.ofbiz.apache.org/accounting/control/FindFinAccount?ownerPartyId=DemoCustomer
>  and deposit some funds into it.
> 2. Create an order for DemoCustomer from the Order Manager application.
> 3. Use "Quick Finalize Order", try paying by the gift card created in step #1.
> Observations - 
> 1. Returns an error "This gift card does not exist"
> Related User ML post - 
> http://mail-archives.apache.org/mod_mbox/ofbiz-user/201403.mbox/%3CCAKuEJqZChmJaWF=rzn1z-vudnzbnsdulj4j6pxjtd5ijynu...@mail.gmail.com%3E
> Thanks.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to