[ 
https://issues.apache.org/jira/browse/OFBIZ-4769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14105070#comment-14105070
 ] 

Jacopo Cappellato commented on OFBIZ-4769:
------------------------------------------

Adrian, I have noticed the code comment you mention too and I think that the 
comment is no more valid (it was based on wrong assumptions or, more likely, 
something was changed elsewhere after).

That code block was committed by David in rev. 915644 with commit log comment: 
{quote}Fixed issue where link parameters where not adjusted for TimeZone, 
though they are expected to be in the event processing which causes links and 
such with times and timestamps, and sometimes dates, to not match what they 
came from; now time zone adjustment is done for link parameters{quote}

As regards replacing the if-else block completely, the direction is good but I 
am worried that this may introduce errors and will need several tests to be 
done (with all the different conversions); since I don't have time for it I 
prefer to touch as less code as possible (but any help is much appreciated).

> Editing of product suppliers is not working for the Germany locale
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-4769
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4769
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: Release 10.04, Release Branch 11.04, Trunk
>            Reporter: Sergei Biletnikov
>            Assignee: Jacques Le Roux
>         Attachments: JIRA-4769-EditProductSuppliers-20121213.diff, 
> JIRA-4769EditProductSuppliers-20121222.patch, 
> JIRA-4769EditProductSuppliers-20121222.patch, 
> JIRA-4769EditProductSuppliers-20121222.patch, OFBIZ-4769-20121227.patch, 
> OFBIZ-4769-Updated.patch, OFBIZ-4769.patch, WidgetWorker.patch, 
> WidgetWorker.patch
>
>
> Please, open any product and add to it a supplier (SupplierProduct), than try 
> to edit it (..../catalog/control/EditProductSuppliers?productId=xxx). 
> It works for English locale, but it does not work for German, I have the 
> following error:
> =-=-=-=-=-=-=-=-= Database type warning GenericEntity.set =-=-=-=-=-=-=-=-= 
> In entity field [SupplierProduct.minimumOrderQuantity] set the value passed 
> in [java.lang.String] is not compatible with the Java type of the field 
> [java.math.BigDecimal]
> Exception: java.lang.Exception
> Message: Location of database type warning
> ---- stack trace 
> ---------------------------------------------------------------
> java.lang.Exception: Location of database type warning
> org.ofbiz.entity.GenericEntity.set(GenericEntity.java:426)
> org.ofbiz.entity.GenericEntity.set(GenericEntity.java:372)
> org.ofbiz.entity.GenericEntity.setAllFields(GenericEntity.java:887)
> ................
> ---- exception report 
> ----------------------------------------------------------
> =-=-=-=-=-=-=-=-= Database type warning GenericEntity.set =-=-=-=-=-=-=-=-= 
> In entity field [SupplierProduct.availableFromDate] set the value passed in 
> [java.lang.String] is not compatible with the Java type of the field 
> [java.sql.Timestamp]
> Exception: java.lang.Exception
> Message: Location of database type warning
> ---- stack trace 
> ---------------------------------------------------------------
> java.lang.Exception: Location of database type warning
> org.ofbiz.entity.GenericEntity.set(GenericEntity.java:426)
> org.ofbiz.entity.GenericEntity.set(GenericEntity.java:372)
> org.ofbiz.entity.GenericEntity.setAllFields(GenericEntity.java:887)
> org.ofbiz.entity.finder.PrimaryKeyFinder.runFind(PrimaryKeyFinder.java:106)
> ..................
> the investigation says me the following:
>    <screen name="EditSupplierProduct">
>         <section>
>             <actions>
>                 <set field="titleProperty" 
> value="PageTitleEditSupplierProduct"/>
>                 <set field="tabButtonItem" value="EditSupplierProduct"/>
>                 <set field="labelTitleProperty" value="ProductSuppliers"/>
>                 <!-- default currency in 
> framework/common/config/general.properties -->
>                 <property-to-field field="defaultCurrencyUomId" 
> resource="general" property="currency.uom.id.default" default="USD"/>
>                 <set field="productId" from-field="parameters.productId"/>
>                 <set field="orderBy" from-field="parameters.orderBy" 
> default-value="partyId"/>
>                 <entity-and entity-name="SupplierProduct" 
> list="productSuppliers">
>                     <field-map field-name="productId"/>
>                     <order-by field-name="${orderBy}"/>
>                 </entity-and>
>                 <entity-one entity-name="SupplierProduct" 
> value-field="supplierProduct" auto-field-map="true"/>
>             </actions
> ...............
> where <entity-one entity-name="SupplierProduct" value-field="supplierProduct" 
> auto-field-map="true"/>  can not be done.
> I suppose that the problem depends on the German locale, where BigDecimal and 
> Date has another format than we have in the parameters via URL.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to