Jacopo Cappellato created OFBIZ-5731:
----------------------------------------
Summary: Misc framework API cleanup
Key: OFBIZ-5731
URL: https://issues.apache.org/jira/browse/OFBIZ-5731
Project: OFBiz
Issue Type: Improvement
Components: framework
Affects Versions: Trunk
Reporter: Jacopo Cappellato
Assignee: Jacopo Cappellato
Fix For: Upcoming Branch
Main commits are listed below:
r1619858:
Small simplification: thread safety is now implemented using a static
initialization rather than an AtomicReference.
r1619868:
Removed all but one of the (static) method of TransactionFactory:
* getCursorConnection(...) has been moved to TransactionUtil where it makes
more sense
* removed all the wrappers method around TransactionFactoryInterface methods:
they are not required now that the client code can use the interface methods
r1619871:
Renamed the class org.ofbiz.entity.transaction.TransactionFactory into
org.ofbiz.entity.transaction.TransactionFactoryLoader: this name better
describe its purpose.
r1619976:
EntityConfig now implements the singleton pattern; thread safety is implemented
with a static initialization.
Removed the EntityConfigUtil class whose main purpose was to guarantee that
only one instance of EntityConfig would be initialized (no more required since
now EntityConfig is a singleton); moved a couple of its static methods to the
EntityConfig class.
r1619977:
Call the overloaded method instead of duplicating its content.
r1619979:
Removed dependency of ConnectionFactory on TransactionFactoryLoader.
r1619981:
Small simplification: thread safety is now implemented using a static
initialization rather than an AtomicReference.
r1619982:
Removed all the wrappers methods around ConnectionFactoryInterface methods:
they are not required now that the client code can use the interface methods.
r1619984:
Moved the logic to create unmanaged connections from ConnectionFactory to
DatabaseUtil where it made more sense (it is the only place where it can be
used, so made it private).
r1619985:
Renamed the class org.ofbiz.entity.jdbc.ConnectionFactory into
org.ofbiz.entity.jdbc.ConnectionFactoryLoader: this name better describes its
purpose.
r1619995:
Renamed ConnectionFactoryInterface into ConnectionFactory.
Renamed TransactionFactoryInterface into TransactionFactory.
r1619999:
Renamed DumbFactory into DumbTransactionFactory.
Renamed JNDIFactory into JNDITransactionFactory.
r1620280:
Two small optimizations to TransactionUtil:
* since the information stored in allThreadsTransactionBeginStack and
allThreadsTransactionBeginStackSave was only used when the log INFO level was
ON, now they are not populated if it is OFF
* instead of reading the value of debugResources from EntityConfig everytime,
now it does only at initialization
r1620286:
Removed some old deprecated methods; removed some old comments; fixed some
typos in comments and logs; removed redundant class name from log messages.
r1620316:
Made connection-factory element in entityengine.xml optional: in fact there are
transaction managers that do not depend an external connection pool because it
is already integrated (e.g. Atomikos Transaction Essentials).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
