Thanks Adrian for review. New patch has been uploaded using clone-value tag to 
clone the immutable generic value.

Thanks & Regards
—
Deepak Dixit

On Sep 20, 2014, at 12:13 PM, Adrian Crum <[email protected]> 
wrote:

> This doesn't fix the problem, it only hides it. If client code wants to 
> modify an immutable GenericValue, then it needs to copy it.
> 
> Adrian Crum
> Sandglass Software
> www.sandglass-software.com
> 
> On 9/20/2014 7:16 AM, [email protected] wrote:
>> Author: ashish
>> Date: Sat Sep 20 06:16:29 2014
>> New Revision: 1626385
>> 
>> URL: http://svn.apache.org/r1626385
>> Log:
>> Applied patch from jira issue - OFBIZ-5739 - 
>> copyContentAndElectronicTextandAssoc service broken.
>> Thanks Deepak Dixit for the contribution.
>> 
>> Modified:
>>     
>> ofbiz/trunk/applications/content/script/org/ofbiz/content/content/ContentServices.xml
>> 
>> Modified: 
>> ofbiz/trunk/applications/content/script/org/ofbiz/content/content/ContentServices.xml
>> URL: 
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/script/org/ofbiz/content/content/ContentServices.xml?rev=1626385&r1=1626384&r2=1626385&view=diff
>> ==============================================================================
>> --- 
>> ofbiz/trunk/applications/content/script/org/ofbiz/content/content/ContentServices.xml
>>  (original)
>> +++ 
>> ofbiz/trunk/applications/content/script/org/ofbiz/content/content/ContentServices.xml
>>  Sat Sep 20 06:16:29 2014
>> @@ -159,10 +159,7 @@
>>      </simple-method>
>> 
>>      <simple-method method-name="copyContentAndElectronicTextandAssoc" 
>> short-description="copy a content, electronic text and assocs and set status 
>> in progress">
>> -        <set-service-fields service-name="getContent" map="parameters" 
>> to-map="getC"/>
>> -        <call-service service-name="getContent" in-map-name="getC">
>> -            <result-to-field result-name="view" field="content"/>
>> -        </call-service>
>> +        <entity-one entity-name="Content" value-field="content"/>
>>          <if-not-empty field="content.dataResourceId">
>>              <set-service-fields service-name="getElectronicText" 
>> map="content" to-map="getEt"/>
>>              <call-service service-name="getElectronicText" 
>> in-map-name="getEt">
>> 
>> 

Attachment: smime.p7s
Description: S/MIME cryptographic signature

Reply via email to