Jacques Le Roux created OFBIZ-5819:
--------------------------------------

             Summary: Improve the build-dev ant target
                 Key: OFBIZ-5819
                 URL: https://issues.apache.org/jira/browse/OFBIZ-5819
             Project: OFBiz
          Issue Type: Improvement
          Components: framework
    Affects Versions: Trunk
            Reporter: Jacques Le Roux
            Assignee: Jacques Le Roux
            Priority: Minor
             Fix For: Upcoming Branch


Currently the build-dev ant target always use "svn patch" to apply patches from 
the runtime/patches directory in a dev environment (so typically on your local 
dev machine).

That was fine as long as we did not chain the build-dev in the build target. 
Since we do that (few weeks ago), there is a drawback which was already 
existing with the other build-* targets (test, qa, production) where I ommitted 
to use the failonerror="true" parameter for these targets.

Thought I never got a problem, to guarantee a safe deployment path, I figured 
it would be better to catch a patching issue as early as possible. 

So for the other build-* targets (test, qa, production), I simply added the 
failonerror="true", so far so good.

But for the build-dev ant target, it was not possible because it uses the exec 
ant task and always returns no errors but an output with the echos of the "svn 
patch" command where there might be some issues.

I tried hard to find a solution with the "svn patch" command, but decided 
parsing the echos in the output was not reliable at all (think different 
languages, number of possible issues, etc.).

So I searched another way and found [the Apache ManifoldCF project had 
one|https://svn.apache.org/repos/asf/manifoldcf/trunk/common-build.xml], it's 
great to be in good company ;) !

So I will soon commit an adaptation of their work to replace the current 
build-dev ant target 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to