[
https://issues.apache.org/jira/browse/OFBIZ-5312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14185350#comment-14185350
]
Ingo Wolfmayr commented on OFBIZ-5312:
--------------------------------------
When a file is missing (for example runtime/uploads/.../10000.jpeg) the
application runs into an endless loop.
java.io.FileNotFoundException: No file found: ...runtime/uploads/.../10000.jpeg
[java] at
org.ofbiz.content.data.DataResourceWorker.getContentFile(DataResourceWorker.java:422)
~[ofbiz-content.jar:?]
[java] at
org.ofbiz.content.data.DataResourceWorker.getDataResourceStream(DataResourceWorker.java:1057)
~[ofbiz-content.jar:?]
[java] at
org.ofbiz.content.data.DataEvents.serveObjectData(DataEvents.java:185)
[ofbiz-content.jar:?]
[java] at sun.reflect.GeneratedMethodAccessor68.invoke(Unknown Source)
~[?:?]
[java] at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
~[?:1.7.0_67]
[java] at java.lang.reflect.Method.invoke(Method.java:606)
~[?:1.7.0_67]
[java] at
org.ofbiz.webapp.event.JavaEventHandler.invoke(JavaEventHandler.java:93)
[ofbiz-webapp.jar:?]
[java] at
org.ofbiz.webapp.event.JavaEventHandler.invoke(JavaEventHandler.java:79)
[ofbiz-webapp.jar:?]
[java] at
org.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:755)
[ofbiz-webapp.jar:?]
[java] at
org.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:475)
[ofbiz-webapp.jar:?]
[java] at
org.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:210)
[ofbiz-webapp.jar:?]
[java] at
org.ofbiz.product.category.SeoControlServlet.doGet(SeoControlServlet.java:85)
[ofbiz-product.jar:?]
[java] at javax.servlet.http.HttpServlet.service(HttpServlet.java:620)
[servlet-api-3.0.jar:?]
[java] at javax.servlet.http.HttpServlet.service(HttpServlet.java:727)
[servlet-api-3.0.jar:?]
[java] at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:303)
[tomcat-7.0.55-catalina.jar:7.0.55]
[java] at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
[tomcat-7.0.55-catalina.jar:7.0.55]
[java] at
org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatcher.java:748)
[tomcat-7.0.55-catalina.jar:7.0.55]
[java] at
org.apache.catalina.core.ApplicationDispatcher.doInclude(ApplicationDispatcher.java:604)
[tomcat-7.0.55-catalina.jar:7.0.55]
[java] at
org.apache.catalina.core.ApplicationDispatcher.include(ApplicationDispatcher.java:543)
[tomcat-7.0.55-catalina.jar:7.0.55]
[java] at
org.ofbiz.webapp.view.JspViewHandler.render(JspViewHandler.java:77)
[ofbiz-webapp.jar:?]
[java] at
org.ofbiz.webapp.control.RequestHandler.renderView(RequestHandler.java:987)
[ofbiz-webapp.jar:?]
[java] at
org.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:674)
[ofbiz-webapp.jar:?]
[java] at
org.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:210)
[ofbiz-webapp.jar:?]
[java] at
org.ofbiz.product.category.SeoControlServlet.doGet(SeoControlServlet.java:85)
[ofbiz-product.jar:?]
[java] at javax.servlet.http.HttpServlet.service(HttpServlet.java:620)
[servlet-api-3.0.jar:?]
[java] at javax.servlet.http.HttpServlet.service(HttpServlet.java:727)
[servlet-api-3.0.jar:?]
[java] at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:303)
[tomcat-7.0.55-catalina.jar:7.0.55]
[java] at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
[tomcat-7.0.55-catalina.jar:7.0.55]
[java] at
org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatcher.java:748)
[tomcat-7.0.55-catalina.jar:7.0.55]
[java] at
org.apache.catalina.core.ApplicationDispatcher.doInclude(ApplicationDispatcher.java:604)
[tomcat-7.0.55-catalina.jar:7.0.55]
[java] at
org.apache.catalina.core.ApplicationDispatcher.include(ApplicationDispatcher.java:543)
[tomcat-7.0.55-catalina.jar:7.0.55]
> Proposal: URL-Generation Changes (mostly for SEO reasons but not only)
> ----------------------------------------------------------------------
>
> Key: OFBIZ-5312
> URL: https://issues.apache.org/jira/browse/OFBIZ-5312
> Project: OFBiz
> Issue Type: New Feature
> Components: specialpurpose/ecommerce
> Affects Versions: Trunk
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Minor
> Labels: changes, ecommerce, friendly, seo, url
> Attachments: OFBIZ-5312 - ofbiz-ecommerce-seo.patch, OFBIZ-5312 -
> ofbiz-ecommerce-seo.patch, OFBIZ-5312 - ofbiz-ecommerce-seo.patch, OFBIZ-5312
> - ofbiz-ecommerce-seo.patch, OFBIZ-5312 - ofbiz-ecommerce-seo.patch,
> OFBIZ-5312 - ofbiz-ecommerce-seo.patch, OFBIZ-5312 -
> ofbiz-ecommerce-seo.patch, OFBIZ-5312 - ofbiz-ecommerce-seo.patch, OFBIZ-5312
> - ofbiz-ecommerce-seo.patch, OFBIZ-5312 - ofbiz-ecommerce-seo.patch,
> OFBIZ-5312 - ofbiz-ecommerce-seo.patch, OFBIZ-5312 -
> ofbiz-ecommerce-seo.patch,
> OFBiz-5312-allowpaths-email-jsp-patch-20140625.patch,
> OFBiz-5312-product-ecommerce-seo-20131031.patch,
> OFBiz-5312-product-ecommerce-seo-for-seo-branch.patch,
> OFBiz-5312-product-ecommerce-seo.patch, SeoContextFilter.java.patch,
> classloaderpatch.txt
>
>
> [This was proposed by Paul Piper in Nabble 7 months
> ago|http://ofbiz.135035.n4.nabble.com/Proposal-URL-Generation-Changes-td4639289.html].
> Here is quoted Paul's proposal
> {quote}
> Hey Everyone,
> over at ilscipio (www.ilscipio.com) we developed a set of functional OFBiz
> changes that we believe the entire community could benefit from. The changes
> have been implemented in parts in Syracus (www.syracus.net) for a while now,
> but we figured that some of which are too crucial for ofbiz' success in the
> long run, so we are considering the contribution (as we did with the SOLR
> component).
> As you are probably aware, OFBiz has a pretty uncommon way of generating
> URLs. Most of this has to do with the fact that OFBiz uses a servlet
> (ControlServlet) to handle all requests. The servlet is mounted at /control,
> so that it won't interfere with other servlets. Though functionally valid,
> this has the sideeffect that all urls are actually created on /control, which
> is neither pretty, nor good by any measures of SEO. It also means that a few
> 302 redirects are necessary to forward the user from / to /control/main. It
> also makes requests more complicated, since many forwards are necessary
> whenever somebody wants to move away from this implementation.
> Since this is hurtful to many of the implementers, I wanted to discuss
> whether or not you guys would be interested in the changes we have made. The
> functional changes contain:
> * Removal of /control out of all the urls
> * SEO-friendly URLS
> * Configurable product/category and other URLs
> * Frontpage mapping from /main to /
> It was tested on our end and contains all necessary improvements (Transforms,
> Sample Configuration, Servlets & Filters) for it to be applicable.
> If interested, I would create a new JIRA ticket for this and after a few
> minor internal discussions, we will gladly provide the rest of you with it.
> Regards,
> Paul
> {quote}
> There is even a patch, mostly done by Jinghai Shi, that I attach here. Even
> if it has been already used in [Syracus|http://syracus.net/] since early this
> year, some help would be needed to test it thoroughly in OFBiz.
> Then we should discuss if it's the way to go. I believe it is. Who needs a
> /control/ or /main by default in ecommerce urls? Would you not prefer
> http://localhost:8080/ecommerce/ over
> http://localhost:8080/ecommerce/control/main ?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
