I have removed the unused import in commit revision 1635489. Thanks!
--
Kind Regards,
Ashish Vijaywargiya
On Fri, Oct 24, 2014 at 1:09 AM, Ashish Vijaywargiya <
ashish.vijaywarg...@hotwaxmedia.com> wrote:
> Hello Gil,
>
> I will get back to this conversation in next week. Thanks!
>
> --
> Ashish
>
> ----- gil portenseigne <gil.portensei...@nereide.fr> wrote:
> | I ashish,
> |
> | Is there a reason to introduce these imports in : CategoryServices.java,
> | these might be remains of devel
> |
> | import java.io.Writer;
> | +import java.math.BigDecimal;
> | import java.sql.Timestamp;
> | +import java.util.ArrayList;
> | import java.util.List;
> |
> | [...]
> |
> | import org.ofbiz.entity.util.EntityListIterator;
> | +import org.ofbiz.entity.util.EntityTypeUtil;
> | import org.ofbiz.entity.util.EntityUtil;
> | [...]
> | +import org.ofbiz.service.GenericServiceException;
> |
> | My eclipse tell me they are no use here :).
> |
> | Not so important i guess, but to have less import is better.
> |
> | Other thing is formatting where you remove an empty line for spaces :
> |
> | @@ -237,7 +245,7 @@ public class CategoryServices {
> | }
> |
> | Timestamp nowTimestamp = UtilDateTime.nowTimestamp();
> | -
> | +
> | int viewIndex = 0;
> | try {
> |
> |
> | Best Regards
> |
> | Gil
> |
> |
> | --
> |
> | <www.nereide.fr>
> |
> | Gil Portenseigne
> | Consultant ERP OFBiz
> | Société Néréide
> | 3b Les isles
> | 37270 Veretz
> | Tel : 09 74 53 46 09, puis 1, poste 61
> | Mob : 06 82 740 444
> | www.nereide.fr <http://www.nereide.fr>
> |
> | Membre d'OFBiz France
> | www.ofbiz-fr.org <http://www.ofbiz-fr.org>
> |
>
>
