[
https://issues.apache.org/jira/browse/OFBIZ-5294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14254823#comment-14254823
]
Adrian Crum edited comment on OFBIZ-5294 at 12/20/14 3:49 PM:
--------------------------------------------------------------
This was discussed at length a few years ago. There are two views regarding
this, and Jacques' comment represents one of those views.
Putting "sub-decorators" in CommonScreens.xml makes it difficult to reuse
screen widgets in other components. You end up having to copy the sub-decorator
into your component in order to reuse the screen. From my perspective, that
copying should not be necessary.
So, there is disagreement on the best practice for this. That is why you see
two approaches in the project.
was (Author: [email protected]):
This was discussed at length a few years ago. There are two views regarding
this, and Jacques' comment represents one of those views.
Putting "sub-decorators" on CommonScreens.xml makes it difficult to reuse
screen widgets in other components. You end up having to copy the sub-decorator
into your component in order to reuse the screen. From my perspective, that
copying should not be necessary.
So, there is disagreement on the best practice for this. That is why you see
two approaches in the project.
> Common screen decorators don't follow best practice of being in
> CommonScreens.xml
> ---------------------------------------------------------------------------------
>
> Key: OFBIZ-5294
> URL: https://issues.apache.org/jira/browse/OFBIZ-5294
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: Release Branch 11.04, Release Branch 12.04, Release
> Branch 13.07, Trunk
> Reporter: Pierre Smits
>
> Commonly screen decorators are found in file CommonScreens.xml of the
> component. However, this is not the case for various screens in the Product
> component.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
