[
https://issues.apache.org/jira/browse/OFBIZ-5928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14259111#comment-14259111
]
Divesh Dutta edited comment on OFBIZ-5928 at 12/27/14 6:22 AM:
---------------------------------------------------------------
Hello [~golja],
First of all congratulations for the great work and thanks for uploading
prototype of a Product Association recommender.
I didn't get chance to run the service "getProductAssociationRecommendations"
but I got chance to look into the code of service. I have a question in method
"compareConditionalProbabilities" . In this method, when you are calculating
probability of Y given not X,
{code}
double conditionalProbabilityGivenNotProductId;
if (occurrences[1][0] + occurrences[1][1] > 0) {
conditionalProbabilityGivenNotProductId = (double)
occurrences[1][0] / (double) (occurrences[1][0] + occurrences[1][1]);
} else {
conditionalProbabilityGivenNotProductId = (double)
occurrences[1][0] / (double) (occurrences[1][0] + occurrences[1][1]);
}
{code}
Could you please explain, what this if condition is handling ? Also code in
both the conditions are same. I suspect that, this should not be the case.
I will run the service and tests and give my feedback on this.
was (Author: diveshdut):
Hello Anahita,
First of all congratulations for the great work and thanks for uploading
prototype of a Product Association recommender.
I didn't get chance to run the service "getProductAssociationRecommendations"
but I got chance to look into the code of service. I have a question in method
"compareConditionalProbabilities" . In this method, when you are calculating
probability of Y given not X,
{code}
double conditionalProbabilityGivenNotProductId;
if (occurrences[1][0] + occurrences[1][1] > 0) {
conditionalProbabilityGivenNotProductId = (double)
occurrences[1][0] / (double) (occurrences[1][0] + occurrences[1][1]);
} else {
conditionalProbabilityGivenNotProductId = (double)
occurrences[1][0] / (double) (occurrences[1][0] + occurrences[1][1]);
}
{code}
Could you please explain, what this if condition is handling ? Also code in
both the conditions are same. I suspect that, this should not be the case.
I will run the service and tests and give my feedback on this.
> Prototype of a Product Association recommender
> ----------------------------------------------
>
> Key: OFBIZ-5928
> URL: https://issues.apache.org/jira/browse/OFBIZ-5928
> Project: OFBiz
> Issue Type: New Feature
> Reporter: Anahita Goljahani
> Priority: Minor
> Attachments: recommender.zip
>
>
> Hi all, as anticipated in my ApacheCon Europe presentation 'Introduction to a
> Recommender System for Apache OFBiz' (downloadable from
> https://cwiki.apache.org/confluence/x/OYPfAg), I have developed a prototype
> of a Product Association recommender for OFBiz. Product Association
> recommendations are suggestions of the type 'Customers who bought this item
> also bought:', that are provided to online shoppers to help them in the
> selection of products to buy.
> Attached to this Jira ticket you will find a zip archive containing a
> component named 'recommender', which implements the logic to generate
> Production Association recommendations. The component contains a short guide
> to its functionalities in the main folder. The guide also includes a short
> paragraph that explains how to run a recommender demo.
> I would really appreciate any review, feedback and suggestion by anyone
> interested in this topic.
> Thank you
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
