[ 
https://issues.apache.org/jira/browse/OFBIZ-6270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14506007#comment-14506007
 ] 

Adam Heath commented on OFBIZ-6270:
-----------------------------------

When an external developer compiles their code, there is no class at that point 
in the tree.  Nothing to mention that a deprecation has taken place.  With this 
file added back(and with further documentation, which needs to be added), such 
a warning message will be shown.

The entity system has gone through this deprecation cycle for many of its 
methods.

Plus, this isn't some minor change to the name of a method, nor the addition or 
removal of some method parameter.  This class was completely removed.  No 
attempt at all was made to provide support for outside vendors.  And this new 
class really is super simple.

ps: I didn't implement all ways of using the previously existing code; namely, 
the resolve() logic is no longer valid, there is no way(I think) to request any 
of the available json object types(where calling code doesn't care if a map, 
list, number, string, boolean is returned), or some of the other features that 
were supported.

> base/json/JSON has been removed, with no deprecation window
> -----------------------------------------------------------
>
>                 Key: OFBIZ-6270
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-6270
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: Trunk, 12.04.04
>            Reporter: Adam Heath
>            Assignee: Adam Heath
>            Priority: Critical
>
> The antlr-based json parser(at org.ofbiz.base.json.JSON.cc) was removed last 
> October(2014-10-27).  However, no backwards-compatible class was left in 
> place, with a proper @Deprecation tag applied.
> The proper approach should have been to leave the class in place, adding 
> @Deprecation, and leaving the json-lib.jar in place.  Then, after one 
> successful release, removing the actual code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to