[ 
https://issues.apache.org/jira/browse/OFBIZ-6217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514301#comment-14514301
 ] 

Taher Alkhateeb commented on OFBIZ-6217:
----------------------------------------

Hey guys, thank you for the heads up.

Adam what should I be careful about in terms of UtilGenerics.cast() and would 
you say it would be ill advised to convert Java built-in type (casting) to 
UtilGenerics.cast()? Would you mind taking a quick look at the latest patch and 
giving me your opinion where I might do things differently?

Jacques, OFBIZ-6275 seems to focus on deprecated method calls. I was not able 
to touch the deprecated warnings yet because they were difficult and require 
advanced knowledge in the core framework and/or external libraries which I am 
unable to debug without first downloading the sources to. Do you have any hints 
where I should be more careful / alert?

> fix warnings in trunk on java source code
> -----------------------------------------
>
>                 Key: OFBIZ-6217
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-6217
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: Trunk
>            Reporter: Taher Alkhateeb
>            Assignee: Adrian Crum
>            Priority: Minor
>              Labels: java, warning
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-6217-patch-4.patch, remove_unused_imports.patch, 
> warnings_patch_2.patch, warnings_patch_2.patch
>
>
> Right now, we have 528 warnings on trunk out of which 238 are about raw types 
> and 118 never used imports. So we can already eliminate most of the warning 
> quite quickly.
> I will issue multiple patches to resolve most of these warnings. It might be 
> a bit of a challenge to eliminate the raw types because the generics are not 
> always deducable from the code especially when relying on external APIs



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to