Le 02/06/2015 07:16, Taher Alkhateeb a écrit :
Hi Julien,

I remember in the earlier days of discussion on integrating bootstrap that you 
were the one who initially hesitated about putting bootstrap in the framework 
and you wanted the whole thing isolated outside in the theme
No, I was against to have menu and other html standard structure in the framework.

  (the description of OFBIZ-5840 shows that).

Are there any difficulties that you encountered which made you reconsider 
integrating at the framework level? Why not just apply classes to whatever you 
have in the framework (login screen etc) and then let CSS do its magic?
It could be interesting to have it in the framework to be able to add some tools. I just think about this kind of charts : http://ironsummitmedia.github.io/startbootstrap-sb-admin-2/pages/index.html (area chart, bar chart and donut chart)

I plan to add each charts as a easy to use tool. And I think it could be logical to use a framework tool (bootstrap) and not a tool in an external theme for rendering...

Maybe I have to know what are the criteria to add something in the framework :)

Thanks for your help :)

Julien.

Taher Alkhateeb

----- Original Message -----

From: "Adrian Crum" <[email protected]>
To: [email protected]
Sent: Tuesday, 2 June, 2015 8:07:45 AM
Subject: Re: Bootstrap in framework folder

There is no need to put bootstrap in the framework folder. Any code that
needs it can use the one in the bootstrap theme.

Adrian Crum
Sandglass Software
www.sandglass-software.com

On 6/1/2015 12:45 PM, Julien NICOLAS wrote:
Hello,

I'm working on the bootstrap theme branch and I have a question that
seems to need a full topic.

I want to move the bootstrap framework from the theme folder to
ofbizroot/framework/image/webapp/image.

Why ?
Just because if we need any bootstrap rendering, it will be available in
the framework.
Even if it's for core tools.

I don't want to replace old theme but I want to be allow to use
bootstrap framework anywhere in the software :
- For the login page
- For charts widget
- For new theme

Want do you think ?

Thanks,

Julien.




Reply via email to