I went ahead and fixed this myself.
Adrian Crum
Sandglass Software
www.sandglass-software.com
On 6/8/2015 8:08 AM, Adrian Crum wrote:
You are getting an error because the types don't match. Like I said,
take some time to understand how Java Generics work.
Adrian Crum
Sandglass Software
www.sandglass-software.com
On 6/8/2015 7:56 AM, Taher Alkhateeb wrote:
Hi Adrian,
Thank you for the feedback. Please note this patch is not related to a
compiler warning but rather a compiler error which _only_ happens with
the
ECJ and not with javac. That is why I posted it specifically as a
seperate
patch in the JIRA. When you upgrade to JDK 8 you get a compiler error in
the ECJ. I will revert this commit as soon as I reach my PC as you
requested but this means upon upgrading to JDK 8 OFBiz will not
compile on
eclipse.
Taher Alkhateeb
On Jun 8, 2015 5:48 PM, "Adrian Crum"
<[email protected]>
wrote:
Please revert this. Removing specific types is NOT an acceptable way to
fix compiler errors!
Taher - please stop trying to fix compiler warnings/errors by hiding
them.
Take some time to understand how Java Generics work before you change
anything else.
Adrian Crum
Sandglass Software
www.sandglass-software.com
On 6/8/2015 2:58 AM, [email protected] wrote:
Author: jleroux
Date: Mon Jun 8 09:58:50 2015
New Revision: 1684133
URL: http://svn.apache.org/r1684133
Log:
A patch from Taher Alkhateeb "Upgrade OFBiz to Java JDK 8"
https://issues.apache.org/jira/browse/OFBIZ-6458
2nd step: allows Eclipse EJC to compile, fixes a problem with
compilation
error in eclipse only, it works okay in javac but not in Eclipse EJC
jleroux: this introduces a small "regression" in the code syntax but to
allow users to compile with Eclipse EJC.
Modified:
ofbiz/trunk/framework/entity/src/org/ofbiz/entity/condition/EntityFieldMap.java
Modified:
ofbiz/trunk/framework/entity/src/org/ofbiz/entity/condition/EntityFieldMap.java
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/framework/entity/src/org/ofbiz/entity/condition/EntityFieldMap.java?rev=1684133&r1=1684132&r2=1684133&view=diff
==============================================================================
---
ofbiz/trunk/framework/entity/src/org/ofbiz/entity/condition/EntityFieldMap.java
(original)
+++
ofbiz/trunk/framework/entity/src/org/ofbiz/entity/condition/EntityFieldMap.java
Mon Jun 8 09:58:50 2015
@@ -68,7 +68,7 @@ public final class EntityFieldMap extend
return
Collections.unmodifiableSet(this.fieldMap.keySet()).iterator();
}
- public Iterator<Map.Entry<String, Object>>
getFieldEntryIterator() {
+ public Iterator<?> getFieldEntryIterator() {
return
Collections.unmodifiableMap(this.fieldMap).entrySet().iterator();
}
