+1 Thanks & Regards -- Deepak Dixit
On Friday, August 21, 2015, Jacques Le Roux <jacques.le.r...@les7arts.com> wrote: > I made it, but agree consistency is better +1 > > Jacques > > Le 21/08/2015 15:28, Arun Patidar a écrit : > >> +1. >> >> Thanks & Regards >> --- >> Arun Patidar >> Manager,Enterprise Software Development >> HotWax Systems >> www.hotwaxsystems.com >> >> On Friday 21 August 2015 06:03 PM, Taher Alkhateeb wrote: >> >>> Hi Jacopo, >>> >>> +1 It makes perfect sense to have consistent database "rules" across the >>> different databases to reduce fragmentation and workarounds. >>> >>> Taher Alkhateeb >>> >>> ----- Original Message ----- >>> >>> From: "Michael Brohl" <michael.br...@ecomify.de> >>> To: dev@ofbiz.apache.org >>> Sent: Friday, 21 August, 2015 3:26:24 PM >>> Subject: Re: Should we revert 1530237? >>> >>> Hi Jacopo, >>> >>> I agree that the field length should be equal on every database to avoid >>> migration problems if you change the database. >>> So +1. >>> >>> Regards, >>> >>> Michael Brohl >>> ecomify GmbH >>> www.ecomify.de >>> >>> Am 21.08.15 um 12:34 schrieb Jacopo Cappellato: >>> >>>> Hi all, >>>> >>>> in rev. 1530237 the sql type for Postgres for "comments" and >>>> "description" fields was changed from VARCHAR(255) to TEXT: >>>> >>>> https://fisheye6.atlassian.com/changelog/ofbiz/?cs=1530237 >>>> >>>> The original contribution and discussion can be found here: >>>> >>>> https://issues.apache.org/jira/browse/OFBIZ-1920 >>>> >>>> However I don't think it was a good idea and I suggest to change the >>>> types back to VARCHAR(255) because the new TEXT type allows strings of any >>>> length; all other types definitions (MySQL, Derby etc...) are using >>>> VARCHAR(255) thus limiting the length of "comments" and "description" >>>> fields to 255 characters and now Postgres is the only one that is >>>> different. >>>> >>>> In my opinion we should set postgres to VARCHAR(255) too until we will >>>> decide to change the size for all the dbs. >>>> >>>> Any objections? >>>> >>>> Kind regards, >>>> >>>> Jacopo >>>> >>> >>> >>> >>> >> >> -- Thanks & Regards -- Deepak Dixit www.hotwaxsystems.com
