[
https://issues.apache.org/jira/browse/OFBIZ-6701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14978350#comment-14978350
]
Ritu Raj Lakhera commented on OFBIZ-6701:
-----------------------------------------
Thanks Jacques for looking in this. I agree with you point to use put method.
I am attaching patch file for all content wrapper.
> Category And Product Content wrapper
> ------------------------------------
>
> Key: OFBIZ-6701
> URL: https://issues.apache.org/jira/browse/OFBIZ-6701
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: Release Branch 11.04, Release Branch 12.04, Release
> Branch 13.07, Release Branch 14.12, Trunk
> Reporter: Ritu Raj Lakhera
> Assignee: Jacques Le Roux
> Fix For: Trunk
>
> Attachments: Ofbiz-6701.patch, Ofbiz-6701_Updated_All_Wrapper.patch
>
>
> There are some enhancements in product content wrapper JAVA class. We used
> these enhancements in our project and observed good change in website
> performance.
> 1. If content of product is empty string or null then method
> 'getProductContentAsText' is not caching the result.
> And thus every time this method is making SQL call even no content in
> database. Method should cache the empty string and null as result.
> 2. Overloaded method 'getProductContentAsText' is also using cache method of
> Delegator for 'ProductConetnt' entity selection and passing 'true' to use
> cache for 'ContentWorker.renderContentAsText' method. This approach is making
> unnecessary copies of cache for content.
> I Product content wrapper cache
> II ProductContent entity cache
> III Content, Dataresource, ElectrocText and etc... entities
> cache(ContentWorker.renderContentAsText)
> If I again call the 'getProductContentAsText' method then this will return
> the result from product content wrapper cache. So there is no use of
> ProductContent, Content, Dataresource and ElectrocText cache. And these cache
> also filling the memory of application.
> We also applied the same logic for category content wrapper. I am attaching
> the patch for trunk, please review.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
