Thanks Jacques for reporting , Let me check. Thanks & Regards -- Deepak Dixit www.hotwaxsystems.com
On Sun, Jan 17, 2016 at 4:38 AM, Jacques Le Roux < [email protected]> wrote: > Le 17/01/2016 00:07, Jacques Le Roux a écrit : > >> I did not dive into details but testCreateOrderConfigurableServiceProduct >> reports an issue with this change. >> It was not obvious to me initially because thought Buildbot stopped there >> https://ci.apache.org/builders/ofbiz-trunk it did not report the error >> in tests https://ci.apache.org/projects/ofbiz/logs/ >> I will check that and will add R15.12 soon in Buildbot >> I got the error in Windows w/ another one (service-xml-rpc-local-engine) >> so I checked in Linux and got only the >> testCreateOrderConfigurableServiceProduct error >> I did not check details but I guess the same appears in R14.12: >> https://ci.apache.org/builders/ofbiz-branch14 >> > > And of course R15.12 > > > >> Jacques >> >> Le 16/01/2016 11:58, [email protected] a écrit : >> >>> Author: deepak >>> Date: Sat Jan 16 10:58:26 2016 >>> New Revision: 1724954 >>> >>> URL: http://svn.apache.org/viewvc?rev=1724954&view=rev >>> Log: >>> (OFBIZ-6805) Applied patch from jira issue OFBIZ-6805 >>> ============================================================ >>> Session already invalidate (removeAttribute: Session already >>> invalidated) on destroyCart for anonymous userLogin >>> ============================================================ >>> >>> Thanks Ankush for your contribution. >>> >>> Modified: >>> >>> ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java >>> >>> Modified: >>> ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java >>> URL: >>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java?rev=1724954&r1=1724953&r2=1724954&view=diff >>> >>> ============================================================================== >>> --- >>> ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java >>> (original) >>> +++ >>> ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java >>> Sat Jan 16 10:58:26 2016 >>> @@ -937,12 +937,13 @@ public class ShoppingCartEvents { >>> /** Totally wipe out the cart, removes all stored info. */ >>> public static String destroyCart(HttpServletRequest request, >>> HttpServletResponse response) { >>> HttpSession session = request.getSession(); >>> - clearCart(request, response); >>> session.removeAttribute("shoppingCart"); >>> session.removeAttribute("orderPartyId"); >>> session.removeAttribute("orderMode"); >>> session.removeAttribute("productStoreId"); >>> session.removeAttribute("CURRENT_CATALOG_ID"); >>> + // Call clearCart at the end as if user is anonymous then it >>> will throw session already invalidated error on removeAttribute method. >>> + clearCart(request, response); >>> return "success"; >>> } >>> >>> >>> >>> >>
