[
https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15226050#comment-15226050
]
Gareth Carter commented on OFBIZ-6705:
--------------------------------------
Its been a few months that anyone has posted on this jira, I just want to
highlight (looking at the source files some more) that when manually paging
through data, almost the same source lines are copied and pasted (looking at
OrderLooupServices.java, ShowVisits.groovy and EditShoppingList.groovy but
there could be more, much more...).
Eg
- retrieving viewIndex/viewSize (setting defaults if they don't exist)
- calculating lowIndex/highIndex
- retrieving resultset size
It would be nice, maybe as part of the latest refactoring, to include a method
do all this in one go?
We have implemented something like this in our internal components. We have a
PagedList object (stores list of data items, resultset size, viewSize,
viewIndex, lowIndex (I call it startIndex) and highIndex (called endIndex), we
also have a utils class that returns the PagedList object based on a
EntityListIterator, viewSize and viewIndex. We created this code before
EntityQuery was used but it would certainly be handy to have a method on
EntityQuery as well
> some files set viewIndex to 1 by default rather than 0
> ------------------------------------------------------
>
> Key: OFBIZ-6705
> URL: https://issues.apache.org/jira/browse/OFBIZ-6705
> Project: OFBiz
> Issue Type: Bug
> Reporter: Gareth Carter
> Priority: Minor
>
> The following files set viewIndex to 1
> {noformat}
> ./applications/order/src/org/ofbiz/order/order/OrderLookupServices.java:
> if (viewIndex == null) viewIndex = 1;
> ./applications/order/webapp/ordermgr/entry/catalog/categorydetail.ftl:
> <#--assign viewIndex = viewIndex - 1/-->
> ./applications/order/webapp/ordermgr/WEB-INF/actions/order/FindOrders.groovy:viewIndex
> = request.getParameter("viewIndex") ?
> Integer.valueOf(request.getParameter("viewIndex")) : 1;
> ./applications/party/webapp/partymgr/WEB-INF/actions/communication/ListCommunications.groovy:context.viewIndex
> = 1;
> ./applications/party/webapp/partymgr/WEB-INF/actions/visit/ShowVisits.groovy:
> viewIndex = Integer.valueOf(parameters.VIEW_INDEX ?: 1);
> ./specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/shoppinglist/EditShoppingList.groovy:
> viewIndex = Integer.valueOf(parameters.VIEW_INDEX ?: 1);
> {noformat}
> I ran this command to get the output:
> grep -R --exclude-dir=.svn "viewIndex = " . | grep " 1"
> As far as I am aware, viewIndex starts from 0
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
