[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15264008#comment-15264008
]
Taher Alkhateeb commented on OFBIZ-6783:
----------------------------------------
Thank you gentlemen. Patch is committed in r1741624.
The next items I have in mind for this JIRA is the following:
- To introduce commons-cli. I will keep it in the base component but refer to
it from start
- To remove dependencies from other classes into Start.java. NOTHING should
point to Start.java
- I am thinking of creating an OfbizCommand interface for executing the
commands. Start.java should be a very small high level execution of the
framework with all details hidden away.
- some code need to be simplified
> Refactor start.java
> -------------------
>
> Key: OFBIZ-6783
> URL: https://issues.apache.org/jira/browse/OFBIZ-6783
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: Upcoming Branch
> Reporter: Taher Alkhateeb
> Assignee: Taher Alkhateeb
> Labels: framework, main, refactoring, start
> Attachments: OFBIZ-6783.patch
>
>
> Looking at the main method and design of Start.java looks ugly. The things I
> would like to fix so far are:
> - the file is too long
> - some variables are not even needed (loaderArgs?)
> - the level of abstraction is wrong
> - main throws an exception!
> - the arguments processing logic is terrible, need to move it to commons-cli
> It's just so messy and ugly to look at. So for me refactoring starts at
> Start! Given that this is an important file, I will provide a patch to be
> reviewed by the community before committing just to be on the safe side.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
