[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280625#comment-15280625
]
Jacques Le Roux edited comment on OFBIZ-6783 at 5/11/16 6:59 PM:
-----------------------------------------------------------------
I tried to run "java -jar ofbiz.jar -t" on Win7. It ran, but did not stop, nor
created the HTML results. This could be related (for the non-stop part)
{code}
2016-05-11 20:56:31,257 |Thread-0 |ContainerLoader
|I| Stopped container testtools-container
2016-05-11 20:56:31,257 |Thread-0 |ContainerLoader
|I| Stopping container catalina-container-test
2016-05-11 20:56:31,480 FATAL Unable to register shutdown hook because JVM is
shutting down.
{code}
was (Author: jacques.le.roux):
I tried to run "java -jar ofbiz.jar -t" on Win7. It ran, but did not stop, nor
created the HTML results. This could be related (for the non-stop part)
bq. 2016-05-11 20:56:31,480 FATAL Unable to register shutdown hook because JVM
is shutting down.
> Refactor start.java
> -------------------
>
> Key: OFBIZ-6783
> URL: https://issues.apache.org/jira/browse/OFBIZ-6783
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: Upcoming Branch
> Reporter: Taher Alkhateeb
> Assignee: Taher Alkhateeb
> Labels: framework, main, refactoring, start
> Attachments: OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch,
> StartCommandUtil.java
>
>
> Looking at the main method and design of Start.java looks ugly. The things I
> would like to fix so far are:
> - the file is too long
> - some variables are not even needed (loaderArgs?)
> - the level of abstraction is wrong
> - main throws an exception!
> - the arguments processing logic is terrible, need to move it to commons-cli
> It's just so messy and ugly to look at. So for me refactoring starts at
> Start! Given that this is an important file, I will provide a patch to be
> reviewed by the community before committing just to be on the safe side.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
