[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15284187#comment-15284187
]
Taher Alkhateeb commented on OFBIZ-6783:
----------------------------------------
No, I was wrong. --testlist, now I believe the --testlist actually outputs all
ofbiz tests to either a text file or an ant build file.
This generated file will be consumed by other targets, namely:
- run-test-list: it uses the generated ant script to run all tests, but
stopping ofbiz in between each test
- cobertura-report-xml: not sure how, it's a macro and I need to investigate it.
So, --testlist is rarely used, and I'm not sure what the value of it is. I
think the best thing to do for now is to update the documentation to say
something like "generates an script or text file containing a list of tests".
Also, I discovered some errors which I will correct in the next patch
> Refactor start.java
> -------------------
>
> Key: OFBIZ-6783
> URL: https://issues.apache.org/jira/browse/OFBIZ-6783
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: Upcoming Branch
> Reporter: Taher Alkhateeb
> Assignee: Taher Alkhateeb
> Labels: framework, main, refactoring, start
> Attachments: OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch,
> OFBIZ-6783.patch, OFBIZ-6783.patch, StartCommandUtil.java
>
>
> Looking at the main method and design of Start.java looks ugly. The things I
> would like to fix so far are:
> - the file is too long
> - some variables are not even needed (loaderArgs?)
> - the level of abstraction is wrong
> - main throws an exception!
> - the arguments processing logic is terrible, need to move it to commons-cli
> It's just so messy and ugly to look at. So for me refactoring starts at
> Start! Given that this is an important file, I will provide a patch to be
> reviewed by the community before committing just to be on the safe side.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
