[ 
https://issues.apache.org/jira/browse/OFBIZ-7143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15310236#comment-15310236
 ] 

Montalbano Florian commented on OFBIZ-7143:
-------------------------------------------

The patch is working fine for the trunk version.
To check whether the partyId are empty or not, we should use 
UtilValidate.isEmpty() .

While checking for the problem, I tried to compare this form to the one for 
"ListInvoices". There are some minor differences between the two forms. I think 
we could harmonize these two forms.

1) Definition of the "entityName" for the call of "performFind"
{code}
<set field="entityName" value="Agreement"/>
<field-map field-name="entityName" from-field="entityName"/>
{code} 
or just
{code}
<field-map field-name="entityName" value="Agreement"/>
{code}

2) Name of the first column of the list displayed in the header
{code}
<field name="agreementId" title="${uiLabelMap.CommonEdit}" 
widget-style="buttontext" sort-field="true">
{code}
Result : The first column is named "Edit"
or
{code}
 <field name="agreementId" widget-style="buttontext" sort-field="true">
{code}
Result : The first column is named "Agreement Id"

I don't know which way is the more recent (or the current one which should be 
used).
Does someone know what is the good way ?

> Error on cancelling agreement
> -----------------------------
>
>                 Key: OFBIZ-7143
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7143
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: Trunk
>            Reporter: Ravi Lodhi
>            Assignee: Ravi Lodhi
>            Priority: Minor
>         Attachments: OFBIZ-7143_1412.patch, OFBIZ-7143_1512.patch, 
> OFBIZ-7143_trunk.patch
>
>
> Step to regenerate:
> 1) Go to Agreements screen under Accounting 
> component.(https://localhost:8443/accounting/control/FindAgreement)
> 2) Cancel an agreement from the list.
> 3) See the error on Search Results section.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to