Hi Jacques, Nice work! so it's just the issue of HTML not rendering on failed tests. Ok, I'll jump in and try to see what's up.
Cheers Taher Alkhateeb On Fri, Jun 3, 2016 at 4:47 PM, Jacques Le Roux < [email protected]> wrote: > Hi Taher, > > Took me a while to put it clearly in place, please see > https://issues.apache.org/jira/browse/OFBIZ-7167 > > I will also continue to work on it, but would not be offended if you beat > me on it ;) > > Cheers > > Jacques > > Le 03/06/2016 à 09:25, Taher Alkhateeb a écrit : > >> Hi Jacques, >> >> Ok, my investigation so far reveals the following: >> - the issue definitely happens AFTER r1745351 >> - the issue definitely happens BEFORE r1746236 as it also crashes with the >> same error on 1746228 >> >> So, I think it is not likely to have anything to do with my work on >> OFBIZ-6783. At least this narrows it down to one of the commits in >> between. >> >> Regards, >> >> Taher Alkhateeb >> >> On Fri, Jun 3, 2016 at 12:01 AM, Jacques Le Roux < >> [email protected]> wrote: >> >> Oops, I mean I hate to revert things :) >>> >>> Jacques >>> >>> >>> Le 02/06/2016 à 20:30, Jacques Le Roux a écrit : >>> >>> I agree, I have to revert things, it's the ultimate solution >>>> >>>> BTW I got sidetracked and did not get a chance to look at the problem >>>> today >>>> >>>> Cheers >>>> >>>> Jacques >>>> >>>> >>>> Le 02/06/2016 à 20:19, Taher Alkhateeb a écrit : >>>> >>>> Hi Jacques, >>>>> >>>>> Given your feedback I'm jumping into the test on this issue. I will >>>>> first >>>>> try to run the tests pre r1746228 and compare that with after. If no >>>>> difference then I will go to pre r1744107 but hopefully it won't be >>>>> that >>>>> far back. >>>>> >>>>> Either way, I recommend we don't revert anything and instead dig out >>>>> whatever the culprit is. There is too much work that went into the >>>>> start >>>>> component. I'll go full force in this direction for now. >>>>> >>>>> Regards, >>>>> >>>>> Taher Alkhateeb >>>>> >>>>> On Thu, Jun 2, 2016 at 4:35 PM, Jacques Le Roux < >>>>> [email protected]> wrote: >>>>> >>>>> Hi Arun, >>>>> >>>>>> As you check by yourself this did not fix the issue >>>>>> https://ci.apache.org/builders/ofbiz-trunk >>>>>> >>>>>> But I see that Anurag wants now to continue to work on it, so >>>>>> hopefully >>>>>> he >>>>>> will find the cause >>>>>> >>>>>> Thanks >>>>>> >>>>>> Jacques >>>>>> >>>>>> >>>>>> Le 02/06/2016 à 07:03, Arun Patidar a écrit : >>>>>> >>>>>> Hi Jacques, >>>>>> >>>>>>> I am looking into it. This should fix with the patch attached on >>>>>>> ticket >>>>>>> https://issues.apache.org/jira/browse/OFBIZ-7124. I am testing and >>>>>>> will >>>>>>> commit accordingly. >>>>>>> >>>>>>> Thanks & Regards >>>>>>> --- >>>>>>> Arun Patidar >>>>>>> Manager, Enterprise Software Development >>>>>>> HotWax Systems >>>>>>> www.hotwaxsystems.com >>>>>>> >>>>>>> On Wednesday 01 June 2016 10:19 PM, Jacques Le Roux wrote: >>>>>>> >>>>>>> Le 01/06/2016 à 18:20, Jacques Le Roux a écrit : >>>>>>> >>>>>>>> 1. (At least) One of these 3 changes >>>>>>>> >>>>>>>>> https://ci.apache.org/builders/ofbiz-trunk/builds/759#changes- >>>>>>>>> introduced a test issue in trunk >>>>>>>>> https://ci.apache.org/builders/ofbiz-trunk. >>>>>>>>> Fortunately R15.12 helps use to discern it's most probably r1746459 >>>>>>>>> the >>>>>>>>> culprit https://ci.apache.org/builders/ofbiz-branch15. >>>>>>>>> It could be though that it's more a test to fix than an issue with >>>>>>>>> the >>>>>>>>> data (INVOICE types) >>>>>>>>> >>>>>>>>> I confirm it's r1746459 (and backport related) >>>>>>>>> >>>>>>>> Jacques >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>> >
