[ 
https://issues.apache.org/jira/browse/OFBIZ-7184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15320273#comment-15320273
 ] 

Pranay Pandey commented on OFBIZ-7184:
--------------------------------------

Thanks Deepak, 

I am also thinking, why dataSourceId on the form at first place a not required 
field? and secondly Why shouldn't we auto-sequence it in service if not 
supplied by the user?

The issue can be fixed up anyway but form design should be giving user a 
predictable behavior.

If you look at the screen definition dataSourceId is being set from parameters 
and as this is the case of Create and not update, you don't get the 
dataSourceId. 
{code}
<set field="dataSourceId" from-field="parameters.dataSourceId"/>
{code}
If not found in parameter it should have been set to null, that's the issue we 
have at framework level.



> 'Data Source Id' should be editable/visible on error view screen of 
> createDataSource
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-7184
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7184
>             Project: OFBiz
>          Issue Type: Bug
>          Components: marketing
>    Affects Versions: Trunk
>            Reporter: Chandan Khandelwal
>            Assignee: Vaibhav Jain
>         Attachments: screenshot-1.png
>
>
> Steps to regenerate the issue-
> # Go to https://localhost:8443/marketing/control/main
> # Click on sub-menu DataSource
> # Click on create data source
> # Click "Save" without filling input fields
> # Instead of input field, label is shown Could not be found: []
> (Please refer screenshot for more details)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to