Hi Michael Jacques and everyone, So I also want to confirm that you really need the following tasks:
- build-dev - build-production - build-qa - build-test - revert-dev Are you using them yourselves? Here are the reasons why I suggest to remove them: - First, you must have the patch command existing in your environment, thus making the build script brittle - Second, it has this weird naming convention for patches and how they should be applied. I would imagine that every team and every company has its own style and methodology for patching and keeping track of files and changes. They use their own version control system and even different kinds of patches - It is dependent on a specific format of diff which you must generate either with svn diff or diff -Naur. It seems like it does not make a lot of sense to keep something like that when companies might completely ignore it and choose their own implementation strategies. Do you agree? Feedback? Taher Alkhateeb On Wed, Jun 22, 2016 at 4:01 PM, Jacques Le Roux < [email protected]> wrote: > I wonder though why this was introduced. If we have no feedback from any > member of the community I think we can drop it. I don't see how to use it. > > Jacques > > > > Le 22/06/2016 à 14:43, Michael Brohl a écrit : > >> Hi Taher, >> >> no, I don't use it myself. This was just a guess by looking what the task >> does and it seemed to me this should be preserved. >> No problem to drop it from my side. >> >> Regards, >> >> Michael Brohl >> ecomify GmbH >> www.ecomify.de >> >> >> Am 22.06.16 um 14:37 schrieb Taher Alkhateeb: >> >>> Hi Michael, >>> >>> Are you sure you are using "run-test-list"? This is an old task using a >>> target on the server called --testlist which essentially creates an ant >>> file of all the suites in OFBiz and runs them one-by-one stopping OFBiz >>> in >>> between each run. >>> >>> To me it seems like run-tests is doing the same thing but faster. Is >>> this a >>> typo by you or are you actually using this target? The reason I ask is >>> because I actually wanted to delete the entire TestListContainer.java and >>> related files in the future. But now of course I hesitate. >>> >>> Thanks in advance for your feedback. >>> >>> Regards, >>> >>> Taher Alkhateeb >>> >>> On Wed, Jun 22, 2016 at 12:00 AM, Michael Brohl < >>> [email protected]> >>> wrote: >>> >>> Hi Taher, >>>> >>>> First question: >>>> >>>> Don't drop: >>>> >>>> - build-dev >>>> - build-production >>>> - build-qa >>>> - build-test >>>> - refresh >>>> - revert-dev >>>> - run-test-list >>>> >>>> Drop: >>>> >>>> - clean-ivy (assuming this is not needed if we use Gradle) >>>> - copy-dtds >>>> - download-PG-JDBC >>>> - download-activemq >>>> - download-mySQL-JDBC (download tasks: assuming they are not needed if >>>> we >>>> use Gradle/automatic dependency mechanism) >>>> >>>> >>>> Not sure (I don't use them): >>>> >>>> - create-tenant >>>> - load-all-tenants >>>> - load-demo-multitenant >>>> - load-tenant >>>> - load-tenant-data-readers >>>> - gen-kek >>>> - gitinfo >>>> - run-test-list >>>> - start-batch-secure >>>> - start-both-secure >>>> - start-pos-secure >>>> - start-secure (...secure: not sure if these are needed anymore, I think >>>> Jacques can give some hints about them) >>>> - svninfo >>>> >>>> Second question: +1 >>>> >>>> but I'm not sure about the load-tenant... tasks (I don't use them). >>>> >>>> >>>> Regards, >>>> >>>> Michael Brohl >>>> ecomify GmbH >>>> www.ecomify.de >>>> >>>> >>>> Am 21.06.16 um 22:09 schrieb Taher Alkhateeb: >>>> >>>> Hi Everyone, >>>>> >>>>> I have create the JIRA >>>>> https://issues.apache.org/jira/browse/OFBIZ-7534 >>>>> for >>>>> this project >>>>> >>>>> I have two questions in this thread >>>>> >>>>> First Question >>>>> ------------------ >>>>> Can I drop the below tasks from the build system? They currently exist >>>>> in >>>>> Ant but I am not sure whether they are actively used or not. So if you >>>>> want >>>>> me to add any of these tasks please reply to this thread, otherwise I >>>>> will >>>>> not include them in gradle. Please note I added all multi tenant tasks >>>>> because many of them are broken or have no functionality, so I am >>>>> assuming >>>>> people are doing multi-tenancy manually but not sure, so please help! >>>>> >>>>> - build-dev >>>>> - build-production >>>>> - build-qa >>>>> - build-test >>>>> - clean-ivy >>>>> - copy-dtds >>>>> - create-tenant >>>>> - download-PG-JDBC >>>>> - download-activemq >>>>> - download-mySQL-JDBC >>>>> - gen-kek >>>>> - gitinfo >>>>> - load-all-tenants >>>>> - load-demo-multitenant >>>>> - load-tenant >>>>> - load-tenant-data-readers >>>>> - refresh >>>>> - revert-dev >>>>> - run-test-list >>>>> - start-batch >>>>> - start-batch-secure >>>>> - start-both-secure >>>>> - start-pos-secure >>>>> - start-secure >>>>> - svninfo >>>>> >>>>> Second Question >>>>> ----------------------- >>>>> >>>>> it seems many of the load tasks are too specific. So I suggest to only >>>>> implement loadDemo and the rest are executed manually by users, for >>>>> example: ./gradlew 'ofbiz --load-data reader=seed, seed-initial, ext' >>>>> instead of load-extseed. >>>>> >>>>> If you would like to add the other load data tasks, please specify >>>>> which >>>>> ones. >>>>> >>>>> Appreciate your early responses. >>>>> >>>>> Taher Alkhateeb >>>>> >>>>> >>>>> >>>> >> >> >
