I think both ways are fine but personally I like to do this kind of changes component wise because, -- it's easy to review -- more users and committers can involve -- easy for beginners to contribute
Thanks and Regards -- Akash Jain On Sun, Sep 4, 2016 at 6:30 PM, Jacques Le Roux < [email protected]> wrote: > I wonder, it would be a bit easier to commit but the review could be > harder, a moot point I'd say > > Jacques > > > Le 04/09/2016 à 13:47, Michael Brohl a écrit : > >> This might disappear in the many notifications so I'd like to asked the >> below question also here in the dev list. >> What do you think? >> >> Thanks, >> >> Michael Brohl >> ecomify GmbH >> www.ecomify.de >> >> Am 04.09.16 um 13:41 schrieb Michael Brohl (JIRA): >> >>> [ https://issues.apache.org/jira/browse/OFBIZ-8045?page=com. >>> atlassian.jira.plugin.system.issuetabpanels:comment-tabpane >>> l&focusedCommentId=15462791#comment-15462791 ] >>> >>> Michael Brohl commented on OFBIZ-8045: >>> -------------------------------------- >>> >>> I think about doing these changes and all the other similar ones in one >>> single commit and not issue by issue, what do others think about this? >>> >>> Accounting: Consistent form name >>>> -------------------------------- >>>> >>>> Key: OFBIZ-8045 >>>> URL: https://issues.apache.org/jira/browse/OFBIZ-8045 >>>> Project: OFBiz >>>> Issue Type: Sub-task >>>> Components: accounting >>>> Reporter: Tanmay Muley >>>> Assignee: Michael Brohl >>>> Priority: Minor >>>> Fix For: Trunk >>>> >>>> Attachments: OFBIZ-8045.patch, OFBIZ-8045.patch, >>>> OFBIZ-8045.patch >>>> >>>> >>>> Change all form names to upper camel case for consistency. >>>> >>> >>> >>> -- >>> This message was sent by Atlassian JIRA >>> (v6.3.4#6332) >>> >> >> >> >
