Hi Michael,
I prefer to use Implements instead of Implemented. When I commit it's an action, not something in the past. I got this habit while working with an
Englishman: Rupert Howell. Nothing better to get a habit in English language than working with an Englishman. BTW, I still remember Adrian's reaction
when someone tried to learn him how to use English :)
Of course this can be seen as a moot point. I think we need some flexibility, we are not machines. Fortunately they are far from ready to replace us
doing this job ;)
When I saw Jacopo using "Fix for:", I had a doubt (I'd use Fixes). I will finally stick to Fixes to be consistent, but will keep the rest (Improves,
etc.) alike in the TortoiseSVN template.
I did not put "'title" in order to save me to have to remove it. I just write the title after the action. Most of the time the title will come from
the Jira title. Sometimes you need to change it, slightly or not, or to create it if it does not come from Jira.
I guess that you use parenthesis in (OFBIZ-) like IBM use(s/d?) [] in its documentation to denote something optional. That would mean for me to have
to remove them most of the them. I don't want that.
I put blaba, to say that I have to write something here (we use that in French for yada yada). It's a kind of joke here. You can read my commit, I
learnt the hard way how to write something *meaningful* there (mostly thanks to Adam I must say)
Same for "thanks: x for"
You see all what I did, was done on purpose. I committed this template for myself. I guess I'm now the only committers using Windows, hence
TortoiseSVN. It's useless for others, they can forget it, else please chime in.
Now, I totally agree about the proposed template below and it should be the reference for all of us in the wiki. But again we are not robots. I'll not
chase somebody if he uses "Fix for:" instead of "Fixes"
Thanks
Jacques
PS: you say <<Title should be put in the message without "". >> I don't agree,
it's a reference, I prefer to keep quotes around.
Le 10/09/2016 à 22:19, Michael Brohl a écrit :
Hi Jacques,
following the latest version of our template proposal, the correct format would
be:
===
[Implemented|Improved|Fix for|Documentation]: [Jira title|Free text]
[(OFBIZ-xxxx)]
[More detailed explanation of what has been done and what the fix achieves,
sideeffects etc.]
[Thanks:] [xxxx for ... and yyyy for]
===
I think the Tortoise template would then be:
===
Implemented: title
Improved: title
Fix for: title
Documentation: title
(OFBIZ-)
blabla
Thanks: x for
===
Title should be put in the message without "".
Tomorrow I will write down the specs in the Wiki with detailed explanations.
Thanks,
Michael
Am 09.09.16 um 08:55 schrieb [email protected]:
Author: jleroux
Date: Fri Sep 9 06:55:02 2016
New Revision: 1759945
URL: http://svn.apache.org/viewvc?rev=1759945&view=rev
Log:
No functionnal change, only a rough ToirtoiseSvn template for commits, can't
have empty line (removed by ToirtoiseSvn)
Modified:
ofbiz/trunk/ (props changed)
Propchange: ofbiz/trunk/
------------------------------------------------------------------------------
--- tsvn:logtemplatecommit (added)
+++ tsvn:logtemplatecommit Fri Sep 9 06:55:02 2016
@@ -0,0 +1,7 @@
+Implements
+Improvement for
+Documents
+Fix for
+OFBIZ-
+blabla
+Thanks x to for
