Paul, I too stumbled over this some time ago, changed it to a glAccountTypeId and was surprised that the glAccountId wasn't found anymore. Yes, it's irritating and should be changed..
And I agree with Taher to convert this to Groovy (all Minilang ;) Let's start with tests. Christian Am 10.02.2017 09:04, schrieb Paul Foxworthy: > Hi all, > > As you might guess if you've been looking at Jira and the dev list lately, > I've been working on purchases and sales generating GL transactions. > > Please have a look at the createAcctgTransForPurchaseInvoice method in > applications/accounting/minilang/ledger/GeneralLedgerServices.xml > > line 2024 in trunk does this: > > <set field="debitEntry.glAccountTypeId" > from-field="invoiceItem.invoiceItemTypeId"/> > > Wat? > > There are two different sets of values defined in two different places for > invoice item types and GL account types. Surely you can't just copy a value > from one to the other? Shouldn't there be a service right here to find a > decent GL account type based on the invoice item type? > > Later on, the getGlAccountFromAccountType service looks at all sorts of > things to decide the final GL account to use. But the GL Account *type* is > an input to that. > > Am I missing something, or is this a very nasty bug? > > Thanks > > Paul Foxworthy >
