Thanks Wei,
Please All, refer to OFBIZ-9230 to see how I temporarily handled the issue.
I also agree that using GenericEntityException is better than just a permissive
Exception
But I believe we should rather fix the underlying issue I reported there. So I was hesitant to agree with Wei though it's maybe a better way to get to
really fix the issue because it shows it at the UI level and non only in logs.
Jacques
Le 28/02/2017 à 03:35, Wei Zhang a écrit :
Hi,
I found there is a try/catch block to catch Exception in
EntityUtilProperties.getSystemPropertyValue(). Which will catche a NPE
(delegator is null) when this method is called in
framework/widget/templates/HtmlFormMacroLibrary.ftl but we only get a waring
message in the log file.
So I think we should catch GenericEntityException rather than Exception here
to expose NPE or other runtime exceptions.
Thanks,
Wei
-----
程序羊
--
View this message in context:
http://ofbiz.135035.n4.nabble.com/Should-not-catch-Exception-in-EntityUtilProperties-getSystemPropertyValue-tp4702833.html
Sent from the OFBiz - Dev mailing list archive at Nabble.com.
