Le 12/04/2017 à 21:36, Taher Alkhateeb a écrit :
You are right about the revert I got that confused. My problem, however, is
not that of introducing bugs in the code. My problem is committing without
understanding.
Trust me, when I do something I try as much as possible to understand what I'm
doing.
I did not commit w/o understanding, I just did not spot your error.
So after Swapnil's investigation I thought his solution was right. But it was
hard to test, because of randomness, as I explained in the Jira.
That's why I'll always prefer a static typed language like Java over languages
like Groovy, Javascript or Python (you name it)
And believe me, after (well) earning my life with APL for 29 years I know what
I'm talking about.
Here and sometimes before, I find your tone aggressive, and I don't think it
helps.
After "If it's not on ML it does not exist", remember this other ASF mantra:
"Community over Code" https://s.apache.org/AQJ
Finally: I reverted the useless change in trunk at r1791218
Nuff said
Jacques
If some code is misbehaving I don't just comment it out
without understanding what it does.
I have committed a fix, so please revert the comment commit if you haven't
done so already because it is irrelevant and wrong.
On Apr 12, 2017 10:16 PM, "Jacques Le Roux" <[email protected]>
wrote:
Le 12/04/2017 à 19:44, Taher Alkhateeb a écrit :
Your reply indicates that you do not understand what you committed
Jacques!
I trust Swapnil and Deepak and tested the change which worked. But as I
said in the Jira it was a random issue for me so hard to test!
You don't need to go far to know what is the problem, it's right there in
front of you, it's in this email thread with the EXACT line that's causing
the problem. Let me give you a hint:
Build file 'C:\projectsASF\ofbiz-framework\build.gradle' line: 764
Could not get unknown property 'pluginId' for task ':installAllPlugins' of
type org.gradle.api.DefaultTask.
That was not obvious to me, not to Deepak and Swapnil it seems. It's
easier to fix your (not you personally, in general) own errors. Thanks for
finally fixing it at r1791168.
You are fixing incorrect code by commenting out what's triggering it, which
is also triggered by an incorrect earlier revert from you.
Which "incorrect earlier revert"? Without knowing what I did wrong I'll
not progress...
Jacques
On Wed, Apr 12, 2017 at 8:35 PM, Jacques Le Roux <
[email protected]> wrote:
Please explain more or point to links where it's already explained
Thanks
Jacques
Le 12/04/2017 à 18:54, Taher Alkhateeb a écrit :
This commit is completely wrong and poorly thought and does not fix the
root cause.
Please revert
On Wed, Apr 12, 2017 at 7:38 PM, <[email protected]> wrote:
Author: jleroux
Date: Wed Apr 12 16:38:59 2017
New Revision: 1791143
URL: http://svn.apache.org/viewvc?rev=1791143&view=rev
Log:
Fixed: The createTenant Gradle task fails
(OFBIZ-9273)
Problem:
When you enter
bq. gradlew createTenant -PtenantId=test
you get
FAILURE: Build failed with an exception.
* Where:
Build file 'C:\projectsASF\ofbiz-framework\build.gradle' line: 764
* What went wrong:
A problem occurred evaluating root project 'ofbiz'.
Could not get unknown property 'pluginId' for task ':installAllPlugins'
of
type org.gradle.api.DefaultTask.
Investigation:
This issue is due creation of build.gradle file in plugin (with empty
gradle
task defined in it)
Solution:
Comment out build.gradle template content
Thanks: Deepak for confirmation, Swapnil M Mane for the investigation
and
patch
Modified:
ofbiz/ofbiz-framework/trunk/framework/resources/templates/b
uild.gradle
Modified: ofbiz/ofbiz-framework/trunk/framework/resources/templates/
build.gradle
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/
framework/resources/templates/build.gradle?rev=1791143&r1=
1791142&r2=1791143&view=diff
============================================================
==================
--- ofbiz/ofbiz-framework/trunk/framework/resources/templates/bu
ild.gradle
(original)
+++ ofbiz/ofbiz-framework/trunk/framework/resources/templates/bu
ild.gradle
Wed Apr 12 16:38:59 2017
@@ -1,3 +1,4 @@
+/*
dependencies {
//Examples of compile-time and runtime dependencies
@@ -16,3 +17,4 @@ task uninstall {
// uninstall logic for this plugin
}
}
+*/
