[ 
https://issues.apache.org/jira/browse/OLINGO-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13955108#comment-13955108
 ] 

Jan Penninkhof commented on OLINGO-228:
---------------------------------------

Hi [~mirbo],

I have made my own implementation last Friday and it doesn't seem to be to 
complex. Quite some code from the jpa components (for which this has already 
been implemented) can be re-used for this purpose. All code that I needed to 
added was implemented by extending existing classes. Because of that, it didn't 
seem to difficult.

I think it takes a bit of designing as well though. The JPA components seem to 
have the importfunctions in the entities themselves. I didn't directly find 
this very logical, as they are also not enclosed in the entity in the metadata 
document as well. In my implementation, I have chosen to create a new 
annotation "EdmFunctionImports" (note the s), that identifies a class 
containing function imports. This annotation will also contain the name space 
and container for all function imports in that class. In turn, all methods 
inside that class that have the EdmFunctionImport annotation are then added to 
the function imports collection.

Anyway, thanks very much for considering to add this to Olingo. If I could be 
of any help, please do let me know.

Cheers,
Jan



> AnnotationEdmProvider doesn't detect Function Imports
> -----------------------------------------------------
>
>                 Key: OLINGO-228
>                 URL: https://issues.apache.org/jira/browse/OLINGO-228
>             Project: Olingo
>          Issue Type: New Feature
>          Components: odata2-annotation
>    Affects Versions: V2 1.2.0
>            Reporter: Jan Penninkhof
>
> The AnnotationEdmProvider class doesn't seem to take funtion imports in 
> account. It would be great if it would detect the @EdmAnnotationEdmProvider 
> annotations.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to