Hi, Daniel has already opened two issues to JIR (issue-250, and issue-249), and then he wants to fix these two issues and contribute to apache Olingo, but currently Daniel is not the olingo committer, so how could he proceed?
Best Wishes, Bing -----Original Message----- From: Klevenz, Stephan [mailto:[email protected]] Sent: Tuesday, April 22, 2014 3:38 PM To: [email protected] Subject: Re: Request for fixes on DataJS-1.* Hi, Can you please open an issue here and assign it to component 'datajs': https://issues.apache.org/jira/browse/OLINGO/?selectedTab=com.atlassian.jir a.jira-projects-plugin:summary-panel Thanks, Stephan On 22.04.14 03:01, "Daniel Molina" <[email protected]> wrote: >Hi guys, > >We found two issues on DataJS that we would like to get fixed. Can you >advice on how to proceed? > >Thanks, >Daniel > > >Issue 1 >We found an issue in the handling of single quotes (') in the >"formatLiteral" function (line 6879 in datajs-1.1.2.js): > > var formatLiteral = function (value, type) { > >... > > value = encodeURIComponent(value.replace("'", "''")); > > >The problem is that value.replace("'", "''") replaces only the first >occurrence of ', not all of them which is the intended behavior. The >code should be: > > value = encodeURIComponent(value.replace(/'/g, "''")); > > >Issue 2: >The jsonLightPayloadInfo function (line 7083 in datajs-1.1.2.js) uses >the URI coming from the metadata (data[metadataAnnotation]) and parses >into more meaningful object (fragment). The problem is that it never >calls decodeURIComponent to ensure data is represented correctly. Thus >the lookup performed by lookupEntitySet fails in scenarios where the >URL data was escaped as container.entitySet uses non-escaped values. >The fix should be (line 7112): > >var fragment = decodeURIComponent(metadataUri.substring(fragmentStart + >1, fragmentEnd)); > >
