Hi Francesco,

Thanks for feedback.

I already looked at the source code and improved it.
Unfortunately in the 'AtomDeserializer' and 'ODataBinderImpl' I can only
add an 'SuppressWarning' because the cast is necessary and a refactor
would blow up the code.
If you have a better solution, I'm open to it ;o)

Kind regards,
Michael





On 30.06.14 08:29, "Francesco Chicchiriccò" <ilgro...@apache.org> wrote:

>Hi Michael,
>I've built the master after your latest changes; everything works fine
>with Java 7; with Java 6, while the build runs successfully, I got some
>warnings:
>
>[WARNING] 
>/home/ilgrosso/work/olingo4/lib/commons-core/src/main/java/org/apache/olin
>go/commons/core/serialization/JsonDeserializer.java:[344,39]
>[unchecked] unchecked cast
>found   : java.lang.Object
>required: java.util.List<org.apache.olingo.commons.api.data.Property>
>[WARNING] 
>/home/ilgrosso/work/olingo4/lib/commons-core/src/main/java/org/apache/olin
>go/commons/core/serialization/AtomDeserializer.java:[170,109]
>[unchecked] unchecked cast
>found   : java.lang.Object
>required: java.util.List<org.apache.olingo.commons.api.data.Property>
>
>[WARNING] 
>/home/ilgrosso/work/olingo4/lib/client-core/src/main/java/org/apache/oling
>o/client/core/serialization/v4/ODataBinderImpl.java:[233,60]
>[unchecked] unchecked cast
>found   : java.lang.Object
>required: java.util.List<org.apache.olingo.commons.api.data.Property>
>
>[WARNING] 
>/home/ilgrosso/work/olingo4/ext/client-proxy/src/main/java/org/apache/olin
>go/ext/proxy/commons/ComplexInvocationHandler.java:[185,45]
>[unchecked] unchecked call to add(E) as a member of the raw type
>java.util.Collection
>
>Regards.
>
>On 30/06/2014 07:44, Bolz, Michael wrote:
>> Hi together,
>>
>> As announced I "pushed" the changes from the "Olingo-317 Feature" branch
>> into "master" branch.
>>
>> Commit "Merge branch 'master' into Olingo-317_DeSerializerRefactoring"
>> with ID: (adcf933d52425c93ce57d5f280a33b3a2c609211)
>> Git Commit: http://s.apache.org/Olingo-317-master or [1]
>> Git Branch: http://s.apache.org/Olingo-317 or [2]
>>
>> Kind regards,
>> Michael
>>
>> [1]
>> https://git-wip-us.apache.org/repos/asf?p=olingo-odata4.git;a=commit;h=
>> adcf933d52425c93ce57d5f280a33b3a2c609211
>> [2]
>> 
>>https://git-wip-us.apache.org/repos/asf?p=olingo-odata4.git;a=shortlog;h=
>>re
>> fs/heads/Olingo-317_DeSerializerRefactoring
>>
>>
>>
>> On 27.06.14 14:46, "Bolz, Michael" <michael.b...@sap.com> wrote:
>>
>>> Hi together,
>>>
>>> with the last "commit/push" I refactored the 'Value' hierarchy and
>>> according classes.
>>> As result the 'Value' interface was removed and functionality was
>>>moved in
>>> 'Valuable' interface.
>>> In addition the '*Value' interfaces (and according '*Impl' classes)
>>>were
>>> also removed (except of 'LinkedComplexValue').
>>>
>>> @All: I would merge this at begin of next week into the master if
>>> there are no objections.
>>> As before feedback is welcome  ;o)
>>>
>>> Commit "[OLINGO-317] Refactoring of 'Value-classes'"
>>> with ID: (a2874142c5fb5478b96f7a0d3083ce81924a9fd2)
>>> Git Commit: http://s.apache.org/0627-Olingo-317 or [1]
>>> Git Branch: http://s.apache.org/Olingo-317 or [2]
>>>
>>> Kind regards,
>>> Michael
>>>
>>> [1]
>>> 
>>>https://git-wip-us.apache.org/repos/asf?p=olingo-odata4.git;a=commit;h=a
>>>28
>>> 7
>>> 4142c5fb5478b96f7a0d3083ce81924a9fd2
>>> [2]
>>> 
>>>"https://git-wip-us.apache.org/repos/asf?p=olingo-odata4.git;a=shortlog;
>>>h=
>>> r
>>> efs/heads/Olingo-317_DeSerializerRefactoring"
>
>-- 
>Francesco Chicchiriccò
>
>Tirasa - Open Source Excellence
>http://www.tirasa.net/
>
>Involved at The Apache Software Foundation:
>member, Syncope PMC chair, Cocoon PMC, Olingo PMC
>http://people.apache.org/~ilgrosso/
>

Attachment: smime.p7s
Description: S/MIME cryptographic signature

Reply via email to