Hi Vikram, Can you please open an Jira issue for this contribution and just add a patch file? I have no concerns by adding this.
Stephan On 10.07.14 10:22, "Vikram Pancholi" <[email protected]> wrote: >Thanks Stephan , Christian >I got the compilation issues sorted out after adding below to server-core >plugin list. m2e was generating the code as expected, but wasn't adding >the >generated directory to build path. Adding to pom did the trick. Do you see >any value in commiting this change. > <plugin> > <groupId>org.codehaus.mojo</groupId> > <artifactId>build-helper-maven-plugin</artifactId> > <version>1.7</version> > <executions> > <execution> > <phase>generate-sources</phase> > <goals> > <goal>add-source</goal> > </goals> > <configuration> > <sources> > ><source>target/generated-sources/antlr4</source> > </sources> > </configuration> > </execution> > </executions> > </plugin> > > >One more point antlr plugin in my eclipse doesnt seem to like below lines >any ideas if these are ignorable. It says no viable alternative pointing >to >"/" symbol. > >//JSON support >BEGIN_OBJECT : WS* ( '{' / '%7B' ) WS*; >END_OBJECT : WS* ( '}' / '%7D' ) WS*; > >BEGIN_ARRAY : WS* ( '[' / '%5B' ) WS*; >END_ARRAY : WS* ( ']' / '%5D' ) WS*; > >Regards, >Vikram Pancholi > >On Wed, Jul 9, 2014 at 7:36 PM, Klevenz, Stephan <[email protected]> >wrote: > >> Hi Vikram, >> >> ANTLR generates Java code during Maven build. Before you import projects >> to Eclipse you have to run >> >> mvn clean install >> >> After that you can create Eclipse projects files by >> >> mvn eclipse:eclipse >> >> All .project, .classpath and .settings files are generated. Then you >>just >> can do a recursive import of existing projects into Eclipse. >> >> See also here [1, 2]. >> >> Regards, >> Stephan >> >> [1] http://olingo.apache.org/doc/maven.html >> [2] http://olingo.apache.org/doc/eclipse.html >> >> On 09.07.14 15:55, "Vikram Pancholi" <[email protected]> wrote: >> >> >Of the four issues observed. >> >1. is fixed after sync up with master ..fixed >> >2. Added lifecycle mapping enteries for the maven time stamp and maven >> >plugin plugin ..looks ok for now >> >3.After importing I am still getting compilation issue related code >> >generation for ANTLR, any explicit changes required ? >> > >> > >> > >> >On Wed, Jul 9, 2014 at 6:45 PM, Amend, Christian >><[email protected] >> > >> >wrote: >> > >> >> Hi Vikram, >> >> >> >> do another git fetch and rebase. There was a bug until 20min ago ☺ If >> >> there are still issues let me know. >> >> >> >> Best Regards, >> >> Christian >> >> >> >> From: Vikram Pancholi [mailto:[email protected]] >> >> Sent: Mittwoch, 9. Juli 2014 15:14 >> >> To: [email protected] >> >> Subject: Initial code base import issues >> >> >> >> Hi, >> >> I have clone the master olingo 4 repo locally. While importing the >> >>code >> >> base i am getting a host of issues. Can you let me know if they are >>to >> >>be >> >> ignored or there are fixes that i need to apply to my environment. >> >> PS : I am using Eclipse kepler , jdk 7 >> >> >> >> >> >>>>----------------------------------------------------------------------- >>>>-- >> >>---------------------------------------- >> >> Issue 1 : while executing mvn clean install >> >> Test failure at olingo-server-test >> >> Running org.apache.olingo.server.core.ODataHandlerTest >> >> Tests run: 8, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.841 >> >>sec >> >> <<< FA >> >> ILURE! - in org.apache.olingo.server.core.ODataHandlerTest >> >> >> >>>>testServiceDocumentDefault(org.apache.olingo.server.core.ODataHandlerTe >>>>st >> >>) >> >> Time >> >> elapsed: 0.037 sec <<< FAILURE! >> >> org.junit.ComparisonFailure: expected:<application/json[]> but >> >> was:<application/ >> >> json[;odata.metadata=minimal]> >> >> at org.junit.Assert.assertEquals(Assert.java:115) >> >> at org.junit.Assert.assertEquals(Assert.java:144) >> >> at >> >> org.apache.olingo.server.core.ODataHandlerTest.testServiceDocumentDef >> >> ault(ODataHandlerTest.java:85) >> >> >> >> Failed tests: >> >> ODataHandlerTest.testServiceDocumentDefault:85 >> >> expected:<application/json[]> b >> >> ut was:<application/json[;odata.metadata=minimal]> >> >> >> >> >> >>>>----------------------------------------------------------------------- >>>>-- >> >>---------------------------------------- >> >> Issue 2 : >> >> While importing project using as maven project : Maven Eclipse >> >> Lifecycle Mapping issues >> >> >> >> Description Resource Path Location Type >> >> Plugin execution not covered by lifecycle configuration: >> >> com.keyboardsamurais.maven:maven-timestamp-plugin:1.0:create >>(execution: >> >> default, phase: validate) pom.xml >>/olingo-server-tecsvc >> >> line 94 Maven Project Build Lifecycle Mapping Problem >> >> Plugin execution not covered by lifecycle configuration: >> >> org.apache.maven.plugins:maven-plugin-plugin:3.2:helpmojo (execution: >> >> help-goal, phase: generate-sources) pom.xml >> >> /pojogen-maven-plugin line 98 Maven Project Build >>Lifecycle >> >> Mapping Problem >> >> Plugin execution not covered by lifecycle configuration: >> >> org.apache.maven.plugins:maven-plugin-plugin:3.2:descriptor >>(execution: >> >> default-descriptor, phase: generate-resources) pom.xml >> >> /pojogen-maven-plugin line 83 Maven Project Build Lifecycle Mapping >> >> Problem >> >> Plugin execution not covered by lifecycle configuration: >> >> org.apache.maven.plugins:maven-plugin-plugin:3.2:descriptor >>(execution: >> >> mojo-descriptor, phase: process-classes) pom.xml >> >> /pojogen-maven-plugin line 92 Maven Project Build >>Lifecycle >> >> Mapping Problem >> >> >> >> >> >> [Inline image 3] >> >> >> >> >> >> >> >>>>----------------------------------------------------------------------- >>>>-- >> >>---------------------------------------- >> >> Issue 3: Antlr code generation issue >> >> If i ignore above errors i am getting compilation issues seems >>antlr >> >> code hasnt been generated. >> >> >> >> >> >> >> >>>>----------------------------------------------------------------------- >>>>-- >> >>---------------------------------------- >> >> >> >> Issue 4 : Antlr eclipse plugin Error >> >> If I use antlr eclipse plugin , with antlr lib 4.2.2. I get code >> >> generation error/warning as below unable to find URILexer.token. >> >> >> >> >> >> >> >>>>----------------------------------------------------------------------- >>>>-- >> >>-------------------------------------------------------------- >> >> >> >> Regards, >> >> Vikram Pancholi >> >> >> >> >> >> >> >> >> >>
