-1
The reason is that all the occurrences of "JavaScript" in setup, release, build
instructions, and the subject of this vote are all "Java Script" with a white
space in the middle. The correct name for JavaScript
(http://en.wikipedia.org/wiki/JavaScript) has no white space. During the vote
for its name, Peter Zentai has also pointed it out and got confirmation from
Sven that it should be "JavaScript" without a white space (see attachment).
Please consider correct it. Other parts of the RC looks very good.
Best,
Yi
-----Original Message-----
From: Klevenz, Stephan [mailto:stephan.klev...@sap.com]
Sent: Friday, September 5, 2014 7:41 PM
To: dev@olingo.apache.org
Subject: Re: [Vote] (RC01) Release of Olingo OData Client for Java Script
-1 because of
there are some small issues in the source archive which should be solved first.
Here are the details:
1. wrong copyright in files
./odatajs/tests/common/rx.js:// Copyright (c) Microsoft Open Technologies, Inc.
All rights reserved.
./odatajs/tests/odata-json-parse-tests.html:Copyright (c) Microsoft Open
Technologies, Inc. All rights reserved.
./odatajs/tests/odatajs-startup-perf-test.html:Copyright (c) Microsoft Open
Technologies, Inc. All rights reserved.
2. missing Apache License header in files
./odatajs/Gruntfile.js
./odatajs/JSLib.csproj
./odatajs/JSLib.sln
./odatajs/Web.config
./odatajs/demo/mypage.html
./odatajs/demo/tester.html
./odatajs/demo/scripts/tools.js
./odatajs/grunt-config/custom-tasks/rat/readme.md
3. README (optional)
I would prefer a readme file in root of source archive that gives a short
explanation what the archive is about and if applicable how to build the
sources.
Apart of this minor issues the candidate looks really good.
Regards,
Stephan
On 05.09.14 12:15, "Kobler-Morris, Sven" <sven.kobler-mor...@sap.com>
wrote:
>Hello,
>
>
>
>this is a vote on the release of "Olingo OData Client for Java Script"
>version 4.0.0-beta-01.
>
>
>
>The vote will be open till Wednesday 10/09/2014 on 2pm CET and passes
>if no vote is (-1).
>
>
>
>[ ] +1 Release this package as Olingo OData Client for Java Script
>version 4.0.0-beta-01.
>
>[ ] -1 Do not release this package because...
>
>
>
>The release candidate is available here:
>
>http://people.apache.org/~mibo/olingo/odatajs/4.0.0-beta-01-RC01/
>
>
>
>The release candidate has been signed through the key 15AB5637 in:
>
>http://keyserver.kjsl.org:11371/pks/lookup?search=0x15AB5637&op=vindex
>
>
>
>The release candidate is based on the sources tagged with 1.2.0-RC02:
>
>https://git-wip-us.apache.org/repos/asf?p=olingo-odata4-js.git;a=shortl
>og;
>h=refs/tags/4.0.0-beta-01-RC01
>
>
>
>The Olingo keys file can be found here:
>
>https://dist.apache.org/repos/dist/release/olingo/KEYS
>
>
>
>For project setup instructions see
>http://olingo.staging.apache.org/doc/javascript/project-setup.html.
>
>For project build instructions see
>http://olingo.staging.apache.org/doc/javascript/project-build.html
>
>For project release instructions see
>http://olingo.staging.apache.org/doc/javascript/project-release.html
>
>
>
>
>
>Release distribution files:
>
>// doc distribution
>
>odatajs-4.0.0-beta-01-RC01-doc.zip
>
>odatajs-4.0.0-beta-01-RC01-doc.zip.md5
>
>odatajs-4.0.0-beta-01-RC01-doc.zip.sha512
>
>
>
>
>
>// library distribution
>
>odatajs-4.0.0-beta-01-RC01-lib.zip
>
>odatajs-4.0.0-beta-01-RC01-lib.zip.md5
>
>odatajs-4.0.0-beta-01-RC01-lib.zip.sha512
>
>
>
>// source distribution
>
>odatajs-4.0.0-beta-01-RC01-sources.zip
>
>odatajs-4.0.0-beta-01-RC01-sources.zip.md5
>
>odatajs-4.0.0-beta-01-RC01-sources.zip.sha512
>
>
>
>Best Regards,
>
>Challen, Michael, Sven
>
>
>
--- Begin Message ---
True, should be JavaScript instead of Java Script, I will correct it.
-----Original Message-----
From: Peter Zentai [mailto:peter.zen...@avangrade.com]
Sent: Donnerstag, 21. August 2014 15:25
To: dev@olingo.apache.org
Subject: Re: [VOTE] Java Script OData client library: naming
Isn't JavaScript one word and not two as in Java Script?
Sorry for not being more productive.
Peter
Sent from Windows Mail
From: Kobler-Morris, Sven<mailto:sven.kobler-mor...@sap.com>
Sent: ?Thursday?, ?August? ?21?, ?2014 ?3?:?22? ?PM
To: dev@olingo.apache.org<mailto:dev@olingo.apache.org>
+1
-----Original Message-----
From: Kobler-Morris, Sven [mailto:sven.kobler-mor...@sap.com]
Sent: Donnerstag, 21. August 2014 12:28
To: dev@olingo.apache.org
Subject: [VOTE] Java Script OData client library: naming
Hi all,
we could like to use following official name for the Java Script OData client
library:
"Olingo OData Client for Java Script"
As artifact name we want to use "odatajs".
(This would lead to short library filenames like "odatajs-<rel>-min.js" or
"odatajs-<rel>-beta-01.js" where <rel> would be the release.)
As java script namespace we want to use "odatajs".
(So in the browser the library features are accessible with
window.odatajs.feature or just odatajs.feature)
The names are considered with respect to legal issues, good naming, use as
namespace, and recognition value of OData.
please reply:
[ ] +1 If you agree with the suggested names
[ ] +0 If you don't care.
[ ] -1 Do not agree because...
regards,
Sven
--- End Message ---