[ 
https://issues.apache.org/jira/browse/OLINGO-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14156580#comment-14156580
 ] 

Michael Bolz commented on OLINGO-444:
-------------------------------------

Hi [~rareddy],

I was a little to slow with my proposal (and 
[push|https://git-wip-us.apache.org/repos/asf?p=olingo-odata4.git;a=commit;h=1971a90c799aea076328d95612e2294666a278c6])
 based on your contribution.

After merging I have done a review and changed it in two points.
* I extracted the {{readEntityProperty}} method into an own 
{{PropertyProcessor}} which contains two methods. First to read a *property* 
and second to read the *value of a property*. IMHO such a interface is more 
clear instead of a method with the {{value:boolean}} parameter.
* Additionally I moved the serialization of a *value* away from the 
{{ODataJsonSerializer}} because the raw *value* is represented by default as 
{{text/plain}}. Currently the serialization is in the {{TechnicalProcessor}} 
but this is also not the final place.

Other open points (from my side) are currently:
  * Missing / wrong {{ContextURL}} for property serialization.
  * Missing *Integration Test Cases* for the new functionality

But I think both points can be handled by us during next couple of days (or at 
least next week  ;o) )
And for now I'am looking forward to your feedback.

Kind regards,
Michael

> Addressing Property & $value is not supported
> ---------------------------------------------
>
>                 Key: OLINGO-444
>                 URL: https://issues.apache.org/jira/browse/OLINGO-444
>             Project: Olingo
>          Issue Type: New Feature
>          Components: odata4-server
>    Affects Versions: V4 4.0.0-beta-01
>            Reporter: Ramesh Reddy
>            Assignee: Michael Bolz
>            Priority: Critical
>             Fix For: (Java) V4 4.0.0-beta-02
>
>
> http://docs.oasis-open.org/odata/odata/v4.0/os/part2-url-conventions/odata-v4.0-os-part2-url-conventions.html#_Toc372793783
> http://docs.oasis-open.org/odata/odata/v4.0/os/part2-url-conventions/odata-v4.0-os-part2-url-conventions.html#_Toc372793784
> Both the above features are not supported



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to