Hi Michael As I've wrote in the Jira description, according to the javadocs it might not be the right place. I've asked myself, why we need our own decoder if java.net.URLDecode could do?
Ciao & thanks 2014-11-11 6:36 GMT+01:00 Michael Bolz (JIRA) <[email protected]>: > > [ > https://issues.apache.org/jira/browse/OLINGO-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205972#comment-14205972 > ] > > Michael Bolz commented on OLINGO-480: > ------------------------------------- > > Hi [~giacomo], > > I will check how decoding of {{+}} for URLs can (or should) be added. > After a first look the {{Decoder}} seems not to be the right place based > on javadoc comment *Decodes a Java String containing a percent-encoded > UTF-8 String value*. > After the change the {{Decoder}} class does not behave as expected > (because the {{Decoder}} does more then he should). > > Nevertheless, thanks for hinting to this issue and the contribution. > > Kind regards, > Michael > > > good old '+' as a encoding for a space is not handled in Decoder class > > ---------------------------------------------------------------------- > > > > Key: OLINGO-480 > > URL: https://issues.apache.org/jira/browse/OLINGO-480 > > Project: Olingo > > Issue Type: Bug > > Components: odata2-core > > Affects Versions: V2 2.0.1 > > Reporter: Giacomo Pati > > Assignee: Michael Bolz > > Fix For: V2 2.0.2 > > > > Attachments: > 0001-Change-Decoder-class-to-respect-also-as-space.patch > > > > > > A request like wget > http://localhost:8080/SalesOrderProcessing.svc/SalesOrderItems?$filter=Delivered+eq+true > should be accepted as commonly a '+' is encoding a space. The Decoder class > so far only decodes percent-encoded values and leaves the plus sign as is. > The applied patch adds this decoding to the Decoder class (maybe it's not > the right place to put it but I was not able to find any other place) > > > > -- > This message was sent by Atlassian JIRA > (v6.3.4#6332) > -- Giacomo
