[ 
https://issues.apache.org/jira/browse/OLINGO-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14258437#comment-14258437
 ] 

Lior Okman commented on OLINGO-193:
-----------------------------------


Hi Michael,

I see you reverted the part I had added to reuse code between the Spring root 
locator and the non-spring one. I am concerned that this causes core code to be 
located outside of the core library, meaning it is easy to forget fixing the 
root locator implementation in the Spring library if the one in the core 
library changes. 

Please see the attached "reuse.diff" that tries to address this problem.


Regards,
Lior

> Olingo on Spring implementation scenarion
> -----------------------------------------
>
>                 Key: OLINGO-193
>                 URL: https://issues.apache.org/jira/browse/OLINGO-193
>             Project: Olingo
>          Issue Type: New Feature
>          Components: odata2-core
>    Affects Versions: V2 2.0.1
>         Environment: Spring
>            Reporter: Jan Penninkhof
>            Assignee: Michael Bolz
>            Priority: Minor
>              Labels: spring
>         Attachments: move-up.diff, reuse.diff, root-locator-reuse.diff, 
> spring-core-olingo.diff, spring.diff, unittests.diff
>
>
> Currently only a imlementation scenario using CXFNonSpringJaxrsServlet is 
> provided. However, to implement OLingo while bootstrapping Spring at the same 
> time, this scenario won't work. Instead probably CXFServlet should be used 
> instead.
> However, CXFServlet has quite a different API and Olingo currently doesn't 
> have wiring to that API.
> It would be excellent if there would be a version of Olingo that could work 
> in a Spring environment as well, e.g. to allow for reuse of existing Spring 
> components.
> Please also refer to a discussion on this topic in the mail-archive:
> https://www.mail-archive.com/[email protected]/msg02186.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to