[ 
https://issues.apache.org/jira/browse/OLINGO-637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14508750#comment-14508750
 ] 

Jonathan Bayle commented on OLINGO-637:
---------------------------------------

Hi [~mirbo],

The proposal fits perfectly the need.

I am a bit worried about the `matrixParameters` param because 
ODataPathSegmentImpl in its constructor does not make shallow copies of the 
lists of String, thus it may create a side-effect if the user modifies the list 
he passed to the factory method.
Also, I think the javadoc for the factory methods should point out that the 
`matrixParameters` param is optional and therefore a null reference may be 
passed.

Regards,
Jonathan.

> Client-side uri parsing
> -----------------------
>
>                 Key: OLINGO-637
>                 URL: https://issues.apache.org/jira/browse/OLINGO-637
>             Project: Olingo
>          Issue Type: New Feature
>    Affects Versions: V2 2.0.3, V2 2.0.4
>            Reporter: Jonathan Bayle
>            Assignee: Michael Bolz
>
> Uri parsing requires instances of PathSegment to work 
> (UriParser.parse(List<PathSegment>)) but PathSegment has no public 
> implementation.
> This forbids its client-side usage.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to