Hi,

I just merged the branch into the master.

Best Regards,
Christian

-----Original Message-----
From: Bolz, Michael [mailto:[email protected]] 
Sent: Montag, 29. Juni 2015 07:57
To: [email protected]
Subject: Re: [Discuss] Remove header name enum in client api

* PGP - S/MIME Signed by an unverified key: 29.06.2015 at 07:57:26

Hi,

I agree with the proposal of Christian (+1).
Perhaps the redundant "public static final” in the “HttpHeader” interface could 
also be removed (a change from an “interface” into an enum is unfortunately not 
possible).

Best regards,
Michael

> On 23 Jun 2015, at 13:21, Amend, Christian <[email protected]> wrote:
> 
> Hi,
> 
> Currently there is a header name enum in the client api. Yet in commons we 
> also have the HTTPHeader interface with constants for the most common 
> headers. Since this seems redundant I would suggest to remove the enum since 
> this enum can never contain all available headers. For convenience there is 
> still the HttpHeader interface in the commons module which allows for an 
> access via constants.
> 
> I have created a branch with the necessary changes[1]. If there are no 
> objections I will go ahead and merge the changes.
> 
> WDYT?
> 
> Best Regards,
> Christian
> 
> [1] 
> https://git-wip-us.apache.org/repos/asf?p=olingo-odata4.git;a=shortlog;h=refs/heads/olingo712


* D046871 <[email protected]>
* Issuer: SAP-AG - Unverified

Reply via email to