Hi Dave,

I don’t think that there would be a problem using woodstox. 
At lease with Olingo V2 replacing “woodstox” with “aalto-xml” worked without 
known issues.
But to be sure I would recommend to test it extensive before use it in any 
productive environment.

However, IMHO the suggested change (in 
https://issues.apache.org/jira/browse/OLINGO-799 
<https://issues.apache.org/jira/browse/OLINGO-799>)
should be done in Olingo (master). So that an user has the possibility to 
change the used "XML Input Factory".

If there are no objections about this change I would commit / merge it  at end 
of this week.

Best Regards,
Michael

> On 09 Oct 2015, at 21:56, Vilaverde, David <dvilave...@informatica.com> wrote:
> 
> Hi Michael,
> 
> Do you think there would be a problem with using woodstox (wstx-asl) instead 
> of aalto-xml?  I have a situation where metro and olingo are both on the 
> classpath and aalto-xml on the classpath causes metro to truncate some text 
> nodes in the SOAP payload.  As soon as we remove aalto-xml from the classpath 
> metro behaves normally.  
> 
> I guess the real question is there a requirement for aalto-xml or will any 
> stax library work?  
> 
> In any case I'll put in a JIRA issue and provide a patch/pull request via 
> github.
> 
> Thanks
> 
> Dave
> 
> -----Original Message-----
> From: mibo [mailto:m...@apache.org] 
> Sent: Friday, October 09, 2015 12:53 PM
> To: dev@olingo.apache.org
> Subject: Re: [DISCUSS] aalto-xml dependency
> 
> Hi David,
> 
> IMHO the change should be safe as long as Olingo only have one 
> „XMLInputFactory“ in the dependencies/classpath (aalto-xml).
> So JIRA issue and the „one liner patch“ is welcome.
> 
> BTW, I tested also Olingo V2 with „com.fasterxml:aalto-xml:0.9.10“...
>       System.setProperty("javax.xml.stream.XMLInputFactory", 
> "com.fasterxml.aalto.stax.InputFactoryImpl");
> …and all „core“ tests worked without a problem.
> 
> Best Regards,
> Michael
> 
>> Am 09.10.2015 um 17:04 schrieb Vilaverde, David <dvilave...@informatica.com>:
>> 
>> We currently use both OData V2 and V4.
>> 
>> Is it safe to change the FACTORY from explicitly depending on aalto-xml to 
>> using XMLInputFactory.newInstance()?
>> 
>> If so I will gladly create a JIRA and work on a patch to contribute back.
>> 
>> Thanks
>> 
>> David
>> 
>> -----Original Message-----
>> From: mibo [mailto:m...@apache.org]
>> Sent: Friday, October 09, 2015 10:01 AM
>> To: dev@olingo.apache.org
>> Subject: Re: [DISCUSS] aalto-xml dependency
>> 
>> Hello Dave,
>> 
>> one question, do you use Olingo V2 or V4 or both?
>> 
>> For Olingo V4 there exists currently no way to change the used 
>> XMLInputFactory in the „ODataXmlDeserializer"
>>      private static final XMLInputFactory FACTORY = new InputFactoryImpl();
>> 
>> For Olingo V2 you can set the „System Property“ to change the used 
>> „XMLInputFactory/XMLOutputFactory“.
>> See example below for Woodstox/Default JDK6.
>> 
>>      Woodstox:
>>        System.setProperty("javax.xml.stream.XMLInputFactory", 
>> "com.ctc.wstx.stax.WstxInputFactory");
>>        System.setProperty("javax.xml.stream.XMLOutputFactory", 
>> "com.ctc.wstx.stax.WstxOutputFactory");
>>      Default JDK6:
>>        System.setProperty("javax.xml.stream.XMLInputFactory", 
>> "com.sun.xml.internal.stream.XMLInputFactoryImpl");
>>        System.setProperty("javax.xml.stream.XMLOutputFactory", 
>> "com.sun.xml.internal.stream.XMLOutputFactoryImpl");
>> 
>> Best Regards,
>> Michael
>> 
>>> Am 09.10.2015 um 15:29 schrieb Vilaverde, David 
>>> <dvilave...@informatica.com>:
>>> 
>>> Hi,
>>> 
>>> I currently have a product in which I am using Metro and OLingo.  The Metro 
>>> stack depends on wstx-asl and olingo on aalto-xml and I'm running into 
>>> issues where the XMLInputFactory finds aalto-xml over wstx-asl which is 
>>> causing other serialization issues for Metro.  I tried removing aalto-xml 
>>> from the classpath but then I have issues with OData V4 XML because of a 
>>> NoClassDefFound exception when initializing ODataXmlDeserializer.  I 
>>> noticed the org.apache.olingo.odata2.core.commons.XmlHelper doesn't 
>>> directly import aalto but instead uses XMLInputFactory.newInstance(), so 
>>> the question is can all other usages of aalto be replaced with 
>>> XMLInputFactory or XMLOutputFactory, etc?
>>> 
>>> If so, I would gladly open a Jira issue and contribute a patch back to the 
>>> OLingo project via github.
>>> 
>>> Dave
>>> 
>> 
> 

Attachment: smime.p7s
Description: S/MIME cryptographic signature

Reply via email to