[ 
https://issues.apache.org/jira/browse/OLINGO-793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14969216#comment-14969216
 ] 

Ramesh Reddy commented on OLINGO-793:
-------------------------------------

Scale default I can understand, as per the enforcement of Precision default to 
0 does not make sense to me. It is easy enough to define some valid defaults in 
my case.

I think my real issue here is, when Precision is not specified on temporal 
values, I can understand EdmDateTimeOffset class's "internalValueOfString" 
throwing exception while checking for facet constrains. This typically being 
used for parsing input in the string from from user. However, the method 
"internalValueToString" should not throw an exception, as that used for 
marshaling the object to string from, as it should just format it according to 
the facets defined on the type, not try to enforce it.

> Precision on EdmDateTimeOffset should be optional
> -------------------------------------------------
>
>                 Key: OLINGO-793
>                 URL: https://issues.apache.org/jira/browse/OLINGO-793
>             Project: Olingo
>          Issue Type: Bug
>          Components: odata4-commons
>    Affects Versions: (Java) V4 4.0.0
>            Reporter: Ramesh Reddy
>
> According to [1] the precision attribute on EdmdateTimeOffset is optional 
> facet that can be defined. However the code [2] fails with 
> IllegalArgumentException is it found to be null.
> [1] 
> http://docs.oasis-open.org/odata/odata/v4.0/errata02/os/complete/part3-csdl/odata-v4.0-errata02-os-part3-csdl-complete.html#_Toc406397957
> [2] 
> https://github.com/apache/olingo-odata4/blob/master/lib/commons-core/src/main/java/org/apache/olingo/commons/core/edm/primitivetype/EdmDateTimeOffset.java#L253



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to